docs: drop the platform from the banner tagline - #3
Merged
Conversation
The banner said "in Linux". FreeBSD support landed in 0.4.0, so the line was wrong. Drop the platform instead of listing both, and the line stays right when a third one arrives. The README paragraph and the table below it still name the platforms. The tagline is shorter now, so textLength follows it and the glyphs keep the width they render at. It is centered under the ASCII art. Signed-off-by: Jaeyoon Choi <j_yoon.choi@samsung.com>
Contributor
Author
|
@safl This is simple change. Please review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The banner tagline said "in Linux", which stopped being true when FreeBSD
support landed in 0.4.0. Dropping the platform keeps the line correct, and
it stays correct if a third one is added. The README paragraph and the
table below it still name the platforms.
The SVG stretches each line to its
textLength, so that value follows theshorter string and the glyphs keep the width they render at. The tagline is
centered under the ASCII art now that it no longer spans the full width.
The README alt text loses the platform too.