issues with clearing setWrapped when erasing#5785
Open
PerBothner wants to merge 1 commit intoxtermjs:masterfrom
Open
issues with clearing setWrapped when erasing#5785PerBothner wants to merge 1 commit intoxtermjs:masterfrom
PerBothner wants to merge 1 commit intoxtermjs:masterfrom
Conversation
Replace clearWrap parameter by start==0 test. Add clearing wrap of folowing line if erasing to end of line. This fixes some minor issues and inconsistencies.
Contributor
Author
|
This has been incorporated into PR #5797. The testsuite changes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you clear to the end of a line (using
eraseInLinewith param 0 or 2) it seems to me you want theisWrappedflag of the following line to be cleared, but that doesn't seem to be happening (based on the tests added toInputHandler.test.ts). There is a special case ineraseInDisplayto un-wrap the following line in theparam==1case - but that code is wrong, because it doesn't addybasetoj. Also, it seems highly inconsistent.I propose for simplicity and consistency we should just clear
isWrappedfor the current line ifstart==0and clearisWrappedfor the following line ifendis the end of the line. I haven't verified if xterm or other terminals do it the same way, but this rule seems simple and logical. As a bonus, we can remove theclearWrapparameter of_eraseInBufferLine.