Add backwards compatibility tests and fix concurrent mutation data loss#59
Merged
Add backwards compatibility tests and fix concurrent mutation data loss#59
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
One-time setup creates a permanent user with known credentials and stored passwords. Tests verify auth, key listing, and password retrieval still work — guarding against breaking changes to auth, encryption, or data format. Closes #56. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Single source of truth for test credentials and expected values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use SHA-3 hashed credentials and AES-encrypted password values matching the frontend's crypto flow. E2E tests now go through the actual UI login. Added backcompat tests to CI workflow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Include concurrency_tests and metrics_tests alongside integration_tests and backcompat_tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
No need to list each test file individually. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xumaple
commented
Apr 11, 2026
xumaple
commented
Apr 11, 2026
xumaple
commented
Apr 11, 2026
xumaple
commented
Apr 11, 2026
Remove verbose doc headers, remove OLD_RAW_USER cleanup code that was never needed on main, and update e2e test to verify passwords decrypt to expected plaintext values through the UI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…in CI Use current_user (re-read after lock) instead of stale user from auth time for stored_passwords count check and re-encryption. Prevents silent data loss when a concurrent add_stored_password runs between auth and lock acquisition. Run concurrency tests 10 times in CI to catch intermittent races. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xumaple
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backcompat_setup.rs, run once manually)change_master_password: the stored passwords count check and re-encryption used stale data from before the lock, so a concurrentadd_stored_passwordcould silently have its password droppedCloses #56
Test plan
🤖 Generated with Claude Code