Skip to content

fix(dropdownToggle): Dropdown not repositioned when window resized #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lerio wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(dropdownToggle): Dropdown not repositioned when window resized #261

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0eed58a
fix(dropdownToggle): Dropdown not aligned when in right side of page
Sep 11, 2015
f2a7772
fix(dropdownToggle): Dropdown not repositioned when window resized
Sep 18, 2015
7fe8dc0
fix(dropdownToggle): Added removeEventListener on destroy
Oct 14, 2015
ab065c0
fix(dropdownToggle): Added removeEventListener on destroy
Oct 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/dropdownToggle/dropdownToggle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ angular.module('mm.foundation.dropdownToggle', [ 'mm.foundation.position', 'mm.f
var left = Math.round(offset.left - parentOffset.left);
var rightThreshold = $window.innerWidth - dropdownWidth - 8;
if (left > rightThreshold) {
left = rightThreshold;
left = left - dropdownWidth + $position.position(element).width;
dropdown.removeClass('left').addClass('right');
}
css.left = left + 'px';
Expand Down Expand Up @@ -90,6 +90,16 @@ angular.module('mm.foundation.dropdownToggle', [ 'mm.foundation.position', 'mm.f
}
};
$document.on('click', closeMenu);

angular.element($window).bind('resize', function() {
Copy link
Copy Markdown
Member

@jbrowning jbrowning Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you use bind() here instead of on() like the rest of the event listeners?

Copy link
Copy Markdown
Member

@jbrowning jbrowning Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to clean up this event listener on $destroy. See https://code.angularjs.org/1.4.7/docs/guide/directive#creating-a-directive-that-manipulates-the-dom

Copy link
Copy Markdown
Author

@lerio lerio Oct 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason for bind(), changing.
Also, added cleanup on $destroy as suggested.

if (!!openElement) {
var left = $position.position(element).left;
if (dropdown.hasClass('right')) {
left = left - dropdownWidth + $position.position(element).width;
}
dropdown.css('left', left);
}
});
}
};

Expand Down