Guard against NULL token in first-entry of collection parse functions#339
Open
SAY-5 wants to merge 1 commit into
Open
Guard against NULL token in first-entry of collection parse functions#339SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four collection-entry parse functions call PEEK_TOKEN in their
if (first)block and dereference the result viatoken->start_markwithout checking for NULL. PEEK_TOKEN returns NULL when yaml_parser_fetch_more_tokens fails, so a read or allocation error there causes a NULL dereference before the mark is pushed.Every other PEEK_TOKEN site in parser.c already guards with
if (!token) return 0;(including the very next statement in each of these functions). This adds the same guard to the first-entry path in yaml_parser_parse_block_sequence_entry, yaml_parser_parse_block_mapping_key, yaml_parser_parse_flow_sequence_entry and yaml_parser_parse_flow_mapping_key.Closes #337. The existing test suite still passes; a direct reproducer would need to inject a read failure mid-stream inside the scanner, which the current tests do not exercise.