forked from bids-standard/bids-specification
-
Notifications
You must be signed in to change notification settings - Fork 0
Add BEP047 audio/video behavioral recordings on top of common media definitions #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 43 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
ee69b4c
feat(beh): add audio and video recording support
bendichter ea2e5d1
fix(metadata): remove invalid enum reference for DatasetType
bendichter e1d95e8
Merge branch 'master' into audio-video-clean
bendichter ffccafc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4707a33
Apply suggestion from @bendichter
bendichter 38310aa
Apply suggestion from @bendichter
bendichter fa98d09
Apply suggestion from @bendichter
bendichter 8884985
Apply suggestion from @bendichter
bendichter 827e7d9
refactor(beh): update title to 'Behavioral recordings' and use filetr…
bendichter 7cacffd
fix(docs): update link to BIDS examples repository for behavioral dat…
bendichter 9b262a3
refactor(beh): streamline description of behavioral recordings in doc…
bendichter 7bc990a
Merge branch 'master' into audio-video-clean
bendichter e8a8bf3
Merge branch 'master' into audio-video-clean
effigies 3ee2c6c
Update src/modality-specific-files/behavioral-experiments.md
bendichter 826e25a
Apply suggestion from @bendichter
bendichter 00e3e26
Apply suggestion from @bendichter
bendichter 25f65e1
Add FLAC audio file extension support for behavioral recordings
bendichter bf00bc6
Add StartTime field for audio/video metadata in BIDS schema
bendichter 540a1e7
Revert "Add StartTime field for audio/video metadata in BIDS schema"
bendichter fc019ae
Clarify behavioral recordings section by adding details on simultaneo…
bendichter d7b1270
correct acquisition entity
bendichter 1c06c08
Merge branch 'master' into audio-video-clean
bendichter e7a2332
Merge branch 'master' into audio-video-clean
bendichter 0b2d464
Merge branch 'master' into audio-video-clean
bendichter 4245b5d
feat: add support for Ogg Vorbis audio format in behavioral recordings
bendichter aead0a4
Apply suggestion from @bendichter
bendichter 3756616
change example height value
bendichter 272516c
change example width value
bendichter 8e50668
Merge branch 'master' into audio-video-clean
bendichter 0704e4a
swap example height and width
bendichter 5df5916
Merge branch 'master' into audio-video-clean
bendichter b11d981
feat(schema): add audio bit depth and camera position metadata
bendichter ff8c605
Merge branch 'master' into audio-video-clean
bendichter 83d3208
Merge branch 'master' into audio-video-clean
bendichter 2f3d1d4
Merge branch 'master' into audio-video-clean
bendichter 98eea5e
Merge branch 'master' into audio-video-clean
bendichter bddeb17
feat(beh): add `_audiovideo` suffix for combined audio-video recordings
bendichter 7bb98a9
feat(beh): add support for still image recordings in behavioral exper…
bendichter 877beeb
feat(beh): add optional License field for audio/video/image recordings
bendichter cc41d49
fix(schema): rename behimage suffix to image for consistency
bendichter 1b1da59
Merge branch 'master' into audio-video-clean
bendichter 029deac
Merge branch 'master' into audio-video-clean
bendichter 8bab3d5
Merge PR #2231 (BEP047 audio/video) into PR #2367 (common media file …
bendichter 21f2d07
Prune BEP047 remnants that duplicate common media definitions
bendichter 736b909
Move flac and AudioBitDepth out to the mediafiles PR
bendichter 1ef6197
Merge branch 'media-extra-formats' into mediafiles-bep047
bendichter 31c95b0
Merge branch 'media-extra-formats' into mediafiles-bep047
bendichter 96a3386
Merge branch 'mediafiles-updated' into mediafiles-bep047
bendichter 8951d39
Rename CameraPosition to DevicePosition and apply to all media suffixes
bendichter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -959,6 +959,13 @@ Descriptors: | |
| - type: array | ||
| items: | ||
| type: string | ||
| Device: | ||
| name: Device | ||
| display_name: Device | ||
| description: | | ||
| Free-form description of the device used to record the data | ||
| (for example, `"iPhone 12"`, `"Canon EOS R5"`). | ||
| type: string | ||
| DeviceSerialNumber: | ||
| name: DeviceSerialNumber | ||
| display_name: Device Serial Number | ||
|
|
@@ -4762,3 +4769,65 @@ iEEGReference: | |
| this field should have a general description and the channel specific | ||
| reference should be defined in the `channels.tsv` file. | ||
| type: string | ||
|
|
||
| AudioDuration: | ||
| name: AudioDuration | ||
| display_name: Audio Duration | ||
| description: | | ||
| Duration of the audio recording in seconds. | ||
| type: number | ||
| exclusiveMinimum: 0 | ||
| unit: s | ||
|
|
||
| AudioBitDepth: | ||
| name: AudioBitDepth | ||
| display_name: Audio Bit Depth | ||
| description: | | ||
| Number of bits per sample in the audio recording. | ||
|
|
||
| Common values include `16`, `24`, or `32`. | ||
| type: integer | ||
| minimum: 1 | ||
|
|
||
| CameraPosition: | ||
| name: CameraPosition | ||
| display_name: Camera Position | ||
| description: | | ||
| Free-form description of the camera placement relative to the subject or scene. | ||
|
|
||
| Examples include "front", "profile-left", "ceiling", "room-corner", or "overhead". | ||
| type: string | ||
|
|
||
| Duration: | ||
| name: Duration | ||
| display_name: Duration | ||
| description: | | ||
| Total duration of the audio or video recording in seconds. | ||
| type: number | ||
| exclusiveMinimum: 0 | ||
| unit: s | ||
|
|
||
| FrameRate: | ||
| name: FrameRate | ||
| display_name: Frame Rate | ||
| description: | | ||
| Frame rate of the video recording in frames per second (for example, `30.0`). | ||
| type: number | ||
| exclusiveMinimum: 0 | ||
| unit: Hz | ||
|
|
||
| Height: | ||
| name: Height | ||
| display_name: Video Height | ||
| description: | | ||
| Height of the video in pixels (for example, `1080`). | ||
| type: integer | ||
| minimum: 1 | ||
|
|
||
| Width: | ||
| name: Width | ||
| display_name: Video Width | ||
| description: | | ||
| Width of the video in pixels (for example, `1920`). | ||
| type: integer | ||
| minimum: 1 | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. all of the above I think should be the ones we added in my branch -- some were renamed to have explicit prefix e.g. ImageWidth etc |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did I forget flac in my PR - push that particular addition to it please