Conversation
…odine (Dockerfile.client)
|
I tried with Also I am not sure why this needs to be in this repo and then clone the code again? |
|
It doesn't need to clone code again, it shouldn't - it should copy it from context. |
|
The |
|
Yes, but it shouldn't. PR author did wrong thing. |
|
Hello, Sorry for wasting your time Originally, I made the Dockerfiles to be self-contained ones, explaining the git clone. Will update that soon. |
|
From my testing, it now works. It was tested using Docker. Please provide errors if any. (also removed the useless git clone :} ) Hope you'll enjoy ! |
|
Can you add multi-stage build to avoid keeping the source code and build tools in the final images? Also remove all non-essential things from the files (old code, ascii art) and move it into a docker directory? It seems there is no standardized way of sharing the build step and using it for two different outputs |
|
Copy that, will do ASAP. Is it ok to keep the ascii art ? Kind of like it tbh :} And I'll look into build steps, to try and make them as versatile as possible. |
… (changes the build command !)
|
Multi stage build added. Removed useless comments (except ascii art :} ) Moved both client and server Dockerfile to a docker/ directory. Added build command as comment. Runner stage also uses ubuntu 24.04. |
|
Hi, nice work over here! I did give a try to the code of this PR, and it was missing a package in the final stage: If you |
Added Dockerfile.server and Dockerfile.client, respectivelly running iodined and iodine on alpine 3.22.0
Build:
Usage: