Add functions rust#59
Conversation
|
@uchitsa thanks for the contribution! The code looks good, but some CI workflows don't pass. Please, check. |
|
@yegor256 let's try the workflows again please |
@yegor256 what should I do for fix it? |
|
@uchitsa try to push to the branch one more time, you should see the output of a new CI job I just added, it will help |
|
@uchitsa the CI is still broken, see the output of the |
kreinba
left a comment
There was a problem hiding this comment.
Requesting changes on one correctness defect at rust/functions.rs:39. The new fibo returns 1 for x<2, which shifts the sequence by one position relative to cpp/functions.cpp and rust/recursion.rs, both of which return x so fib(0)=0. The whole repo compares implementations of the same algorithm across languages, so this file needs to produce the same numbers. The matrix file mirrors the cpp version correctly. Inline comment below.
for issue #9