Security: Reflected XSS in HTML error page rendering#2035
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
The error page template inserts `{errorMessage}` and `{stackTrace}` directly into HTML without escaping. Error messages can include untrusted content (for example, external tool stderr/stdout propagated through exceptions), which could execute script in a browser viewing the error page.
Affected files: error.html
Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Member
|
The new variables are not defined. Is this an automated AI pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The error page template inserts
{errorMessage}and{stackTrace}directly into HTML without escaping. Error messages can include untrusted content (for example, external tool stderr/stdout propagated through exceptions), which could execute script in a browser viewing the error page.Severity:
highFile:
server/src/main/resources/web/error.htmlSolution
HTML-escape all dynamic values before template substitution (error message, stack trace, title, logo placeholders if dynamic). Prefer server-side templating with automatic escaping and only allow explicit safe HTML for tightly controlled fields.
Changes
server/src/main/resources/web/error.html(modified)Testing