Skip to content

chore: depend on protected branches of rcgen, rustls-webpki, rustls#474

Merged
mkmks merged 1 commit intomainfrom
chore/rustls-forks-branches
Mar 20, 2026
Merged

chore: depend on protected branches of rcgen, rustls-webpki, rustls#474
mkmks merged 1 commit intomainfrom
chore/rustls-forks-branches

Conversation

@mkmks
Copy link
Copy Markdown
Contributor

@mkmks mkmks commented Mar 20, 2026

Description of changes

This is a followup to #437. Instead of depending on feature branches of rcgen, webpki and rustls, we should depend on the protected branches (rcgen/main, webpki/rel-0.103, rustls/rel-0.23).

PR Checklist

I attest that all checked items are satisfied. Any deviation is clearly justified above.

  • Title follows conventional commits (e.g. chore: ...).
  • Tests added for every new pub item and test coverage has not decreased.
  • Public APIs and non-obvious logic documented; unfinished work marked as TODO(#issue).
  • unwrap/expect/panic only in tests or for invariant bugs (documented if present).
  • No dependency version changes OR (if changed) only minimal required fixes.
  • No architectural protocol changes OR linked spec PR/issue provided.
  • No breaking deployment config changes OR devops label + infra notified + infra-team reviewer assigned.
  • No breaking gRPC / serialized data changes OR commit marked with ! and affected teams notified.
  • No modifications to existing versionized structs OR backward compatibility tests updated.
  • No critical business logic / crypto changes OR ≥2 reviewers assigned.
  • No new sensitive data fields added OR Zeroize + ZeroizeOnDrop implemented.
  • No new public storage data OR data is verifiable (signature / digest).
  • No unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.
  • Strongly typed boundaries: typed inputs validated at the edge; no untyped values or errors cross modules.
  • Self-review completed.

@mkmks mkmks requested a review from a team as a code owner March 20, 2026 11:31
@cla-bot cla-bot bot added the cla-signed The CLA has been signed. label Mar 20, 2026
Copy link
Copy Markdown
Contributor

@eudelins-zama eudelins-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkmks mkmks merged commit e49052b into main Mar 20, 2026
39 of 43 checks passed
@mkmks mkmks deleted the chore/rustls-forks-branches branch March 20, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants