Skip to content

commonlib: Add test to verify all vulnerabilities have solutions #7467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flintstqne wants to merge 1 commit into
base: main
Choose a base branch
from
Open

commonlib: Add test to verify all vulnerabilities have solutions #7467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .../test/java/org/zaproxy/addon/commonlib/internal/vulns/DefaultVulnerabilitiesUnitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,21 @@ private static void assertVulnerability(
assertThat(vulnerability.getReferences(), hasSize(numberOfReferences));
}

@Test
void shouldHaveSolutionsForAllDefaultVulnerabilities() {

@thc202 thc202 Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better check all main properties like in the previous method (extract one from there) rather than one off for the solutions.

// Given
DefaultVulnerabilities vulnerabilities = new DefaultVulnerabilities(Locale.ROOT);
// When / Then
vulnerabilities
.getAll()
.forEach(
vulnerability ->
assertThat(
"Missing solution for: " + vulnerability.getName(),
vulnerability.getSolution(),
is(not(emptyString()))));
}

@Test
void shouldLoadDefaultVulnerabilitiesForUnknownLocale() {
// Given
Expand Down
Loading