Skip to content

improve double and refactoring #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashWhiteHat wants to merge 5 commits into
base: main
Choose a base branch
from
Open

improve double and refactoring #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14fa9d6
add left shift one
ashWhiteHat Jan 28, 2023
18594a1
replace double logic
ashWhiteHat Jan 28, 2023
bcdbef9
replace square logic
ashWhiteHat Jan 28, 2023
6d29c7f
Merge branch 'zcash:main' into feat/improve-double-and-refactoring
ashWhiteHat Sep 6, 2023
6d0566f
refactor double
ashWhiteHat Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/fields/fp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,12 @@ impl Fp {
/// Doubles this field element.
#[inline]
pub const fn double(&self) -> Fp {
// TODO: This can be achieved more efficiently with a bitshift.
self.add(self)
let d0 = self.0[0] << 1;
let d1 = self.0[1] << 1 | self.0[0] >> 63;
let d2 = self.0[2] << 1 | self.0[1] >> 63;
let d3 = self.0[3] << 1 | self.0[2] >> 63;

(&Fp([d0, d1, d2, d3])).sub(&MODULUS)
}

fn from_u512(limbs: [u64; 8]) -> Fp {
Expand Down
8 changes: 6 additions & 2 deletions src/fields/fq.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,12 @@ impl Fq {
/// Doubles this field element.
#[inline]
pub const fn double(&self) -> Fq {
// TODO: This can be achieved more efficiently with a bitshift.
self.add(self)
let d0 = self.0[0] << 1;
let d1 = self.0[1] << 1 | self.0[0] >> 63;
let d2 = self.0[2] << 1 | self.0[1] >> 63;
let d3 = self.0[3] << 1 | self.0[2] >> 63;

(&Fq([d0, d1, d2, d3])).sub(&MODULUS)
}

fn from_u512(limbs: [u64; 8]) -> Fq {
Expand Down