BEAM Nif integration for Pasta Curves - #79
Open
mariari wants to merge 2 commits into
Open
Conversation
Here we add rustler as a dependency and create serialization derivations for the various types found within pasta_curves. Some extra arguments are given to the new_curve_impl as I could not figure out how to splice strings in rust's macro system
This makes it so that all the changes included have no effect upon the code, if the desired changes are wanted, then add: --features=repr-erlang when using cargo to successuflly have the feature enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added Erlang/Elixir NIF integration into pasta curves using rustler. The feature is feature flagged so it has no effect on the codebase when it is not in use.
Tell me if there is anything I should change, or anything more that needs to be done for this to be considered.
The CI will fail as I have not merged #68 into the topic, I can setup an integration branch with these two topics, if you want to see if CI passes or fails.