Add `migrate_zcashd_wallet` command. by nuttycom · Pull Request #152 · zcash/wallet

nuttycom · 2025-05-22T23:16:20Z

This adds support for importing the secret key material from a zcashd wallet.dat file into zallet.

It does not at present support import of wallet history; a wallet initialized using this command will perform recovery via scanning the chain.

Depends on zcash/librustzcash#1768

…t privkeys.

…of import.

Co-authored-by: Jack Grigg <thestr4d@gmail.com>

The primary purpose of the asynchronous operation of `z_sendmany` is to avoid long proving times in a synchronous call. We don't have any reason to believe that proposal construction should be a long-running process, and it's better to report errors to the user synchronously rather than async, so this change moves all of proposal construction into the synchronous phase of the RPC call.

…ture flags.

nuttycom · 2025-09-12T23:11:54Z

diff from prior review

str4d

utACK cb94bf3 with nits, but blocked on knowing what dependency version we are depending on.

str4d · 2025-09-12T23:41:17Z

+zcash_protocol = { git = "https://github.com/zcash/librustzcash.git", rev = "10caf455e3f52744b5392af226a408b05721f70f" }
+
+zewif = { git = "https://github.com/zcash/zewif.git", rev = "f84f80612813ba00a0a8a9a5f060bd217fa981cc" }
+zewif-zcashd = { git = "https://github.com/zcash/zewif-zcashd.git", rev = "02a98d6236e24819904e084180da9ba0f5c9b5d0" }


Where is this commit from? I can't find it anywhere.

The zewif commit is the tip of zcash/zewif#1.

The zewif-zcashd commit does not correspond to either the tip of https://github.com/zcash/zewif-zcashd or any PR opened on it.

zcash/zewif#1 for zewif
https://github.com/zcash/zewif-zcashd/tree/fix/wallettx_sapling_parsing for zewif-zcashd. It's on PR #1 from my fork; I've also now pushed it to the zcash org repo.

It is not on zcash/zewif-zcashd#1 which is very confusing to me, because I do now see it on that branch.

str4d · 2025-09-13T00:30:07Z

+        let config = APP.config();
+
+        // Start monitoring the chain.
+        let (chain_view, _chain_indexer_task_handle) = ChainView::new(&config).await?;


Non-blocking: if we start any component that fires off a background task, we need to shut it down as well. This particular callsite will be altered by #237 so I will fix this then.

str4d · 2025-09-13T00:38:07Z

+
+            if !account_exists {
+                db_data.import_account_ufvk(
+                    &format!("zcashd legacy sapling {}", idx),


Non-blocking, but for the record this will be incorrect for imported Sapling keys (which are not associated with any legacy account) until #263 is done.

Co-authored-by: Jack Grigg <thestr4d@gmail.com>

str4d

utACK f53923b however CI is still failing. The tests now need to have the new features enabled; something like this in zallet/Cargo.toml should work:

[[test]]
name = "cli_tests"
required-features = ["zcashd-import"]

Place this between [package.metadata.deb] and [dependencies] (I always try to follow the section order in The Manifest Format for consistency).

…eatures

str4d

utACK e46fb92

`CmdRunner` uses `cargo run` under the hood, which can rebuild the main binary. If this runs before `cli_tests` it can alter the features that the latter test expects to be present. We also fix the acceptance tests to tolerate the stderr output maybe containing a rebuild. Co-authored-by: Jack Grigg <jack@electriccoin.co>

str4d

Re-utACK be4d76f

nuttycom commented May 22, 2025

View reviewed changes

Comment thread zallet/src/components/json_rpc/methods/list_addresses.rs

nuttycom marked this pull request as draft May 22, 2025 23:19

nuttycom force-pushed the feature/zcashd_wallet_import branch 7 times, most recently from 099475d to 86d747e Compare May 23, 2025 00:58

This was referenced May 27, 2025

tests(wallet): Add initial framework to test zallet RPC methods ZcashFoundation/zebra#9554

Merged

Create and use a wallet.dat with miner address for QA tests ZcashFoundation/zebra#9557

Closed

nuttycom force-pushed the feature/zcashd_wallet_import branch 4 times, most recently from e2d4ef6 to 17df195 Compare June 6, 2025 21:44

nuttycom marked this pull request as ready for review June 6, 2025 22:00

nuttycom force-pushed the feature/zcashd_wallet_import branch from 2b4d0c7 to 7b2b817 Compare June 9, 2025 20:42

nuttycom marked this pull request as draft June 20, 2025 19:58

nuttycom mentioned this pull request Jun 20, 2025

Add gettransaction #36

Draft

nuttycom force-pushed the feature/zcashd_wallet_import branch 5 times, most recently from b55f231 to b565c41 Compare June 27, 2025 18:41

nuttycom force-pushed the feature/zcashd_wallet_import branch from b565c41 to fa843a2 Compare July 31, 2025 01:38

oxarbitrage mentioned this pull request Aug 19, 2025

Fix CI #197

Merged

nuttycom force-pushed the feature/zcashd_wallet_import branch from fa843a2 to 619d100 Compare August 22, 2025 22:08

nuttycom force-pushed the feature/zcashd_wallet_import branch 3 times, most recently from 7df8b76 to 4c547c3 Compare September 6, 2025 04:33

nuttycom and others added 6 commits September 12, 2025 16:16

Skip coinbase transactions in transparent tree traversal.

0eac2d4

rpc (z_sendmany): Allow spending of funds held by imported transparen…

11d48e8

…t privkeys.

migrate_zcashd_wallet: Decrypt and store wallet transactions as part …

908526c

…of import.

trivial: Move errors to bottom of migrate_zcashd_wallet

ffc5c37

Apply suggestions from code review

d348cc9

Co-authored-by: Jack Grigg <thestr4d@gmail.com>

nuttycom force-pushed the feature/zcashd_wallet_import branch from 91040f5 to c013767 Compare September 12, 2025 22:16

nuttycom added 2 commits September 12, 2025 16:42

Use zcash forks of zewif crates & fix license exemptions.

0db5435

Put zcashd import and transparent key import functionality behind fea…

cb94bf3

…ture flags.

nuttycom force-pushed the feature/zcashd_wallet_import branch from 1da8505 to cb94bf3 Compare September 12, 2025 23:11

nuttycom requested a review from str4d September 12, 2025 23:14

str4d requested changes Sep 13, 2025

View reviewed changes

Apply suggestions from code review

f53923b

Co-authored-by: Jack Grigg <thestr4d@gmail.com>

nuttycom force-pushed the feature/zcashd_wallet_import branch from f9e3faf to f53923b Compare September 13, 2025 01:05

nuttycom requested a review from str4d September 13, 2025 01:06

str4d requested changes Sep 13, 2025

View reviewed changes

Add required feature flags to tests, and update CI to test with all f…

e46fb92

…eatures

str4d approved these changes Sep 14, 2025

View reviewed changes

str4d mentioned this pull request Sep 14, 2025

zcash_client_sqlite: Fix bug in zcashd support migration zcash/librustzcash#1948

Closed

str4d force-pushed the feature/zcashd_wallet_import branch from f54315a to 61700db Compare September 15, 2025 22:24

nuttycom force-pushed the feature/zcashd_wallet_import branch from 61700db to bb3e630 Compare September 15, 2025 23:11

nuttycom enabled auto-merge September 15, 2025 23:12

cli: Add progress updates to zallet migrate-zcashd-wallet

be4d76f

str4d approved these changes Sep 15, 2025

View reviewed changes

nuttycom merged commit f8f1f6c into zcash:main Sep 15, 2025
20 of 21 checks passed

nuttycom deleted the feature/zcashd_wallet_import branch September 15, 2025 23:59

nuttycom mentioned this pull request Sep 16, 2025

Migrate wallet.dat transactions directly, instead of restoring them from the chain. #271

Open

str4d mentioned this pull request Mar 17, 2026

fix: Correct column name in standalone transparent key query #395

Merged

Conversation

nuttycom commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nuttycom commented Sep 12, 2025

Uh oh!

str4d left a comment

Choose a reason for hiding this comment

Uh oh!

str4d Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

str4d Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

nuttycom Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

str4d Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

str4d Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

str4d Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

str4d left a comment

Choose a reason for hiding this comment

Uh oh!

str4d left a comment

Choose a reason for hiding this comment

Uh oh!

str4d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nuttycom commented May 22, 2025 •

edited

Loading