Skip to content

Fix CI #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
str4d merged 1 commit into from
Aug 20, 2025
Merged

Fix CI #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions zallet/src/components/keystore.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,7 @@ impl KeyStore {
Ok(seed_fp)
}

#[allow(dead_code)]
pub(crate) async fn encrypt_and_store_legacy_seed(
Copy link
Copy Markdown
Collaborator

@str4d str4d Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I NACKed this change in #109 because at the time I thought that what is now #152 would be merged shortly, meaning that this change (and the other it proposed) was creating unnecessary work. Ironically we are now in a position where #152 is likely to be merged shortly, but I'm now less averse to this change as long as we do indeed remember to do the additional work to revert it once #152 merges.

&self,
legacy_seed: &SecretVec<u8>,
Expand Down
Loading