rpc: Add transparent information to z_viewtransaction#216
Merged
Conversation
str4d
force-pushed
the
147-z_viewtransaction-transparent
branch
from
44f0aa2 to
de70e46
Compare
nuttycom
requested changes
Sep 3, 2025
Most of the semantics are preserved, but a few are adjusted to make more sense.
This makes the conversions from their (current) source data infallible, and doesn't actually matter in practice because these fields are only used for serializing to JSON numbers (which are arbitrary size).
str4d
force-pushed
the
147-z_viewtransaction-transparent
branch
from
cda29bd to
c650eb9
Compare
Collaborator
Author
|
Force-pushed to fix a bug and clippy lints, and then pushed a commit relaxing some of the numeric field types. |
nuttycom
reviewed
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147.