fix: essentials and pinned removed on ctrl-tab #9012

[Vedaant-Rajoo]

Fix:
✅ Detects essential/pinned tabs
✅ Routes them through onCloseTabShortcut to unload instead of remove
✅ Updates the Ctrl+Tab UI properly (removes preview, updates list)

Fixes #9012

[Vedaant-Rajoo]

Ctrl-Tab is a little finnicky, because we need to define that pinned/essential tabs always get unloaded from that menu.

[mr-cheffy]

Looks good, some minor changes, could you please guide me on how you would remove a tab from the ctrl+tab menu though?

[Vedaant-Rajoo]

I would say, the setting:

should control what happens to the tab on close inside the ctrl Tab menu.

If close tab is selected. I would say we do gbrowser.removeTab() like usual.

Decision up to you.

[Vedaant-Rajoo]

I can edit to make the setting also a condition for the behavior of remove on Ctrl-Tab Menu

[Vedaant-Rajoo]

Is there an update @mr-cheffy ?

[mr-cheffy]

I still don't know how I would remove a tab from the ctrl tab menu though, I couldn't reproduce yet, maybe I'm doing it wrong

[Vedaant-Rajoo]

i dont understand? Do you mean remove as in remove it from the menu or remove it from the sidebar. Or did you mean unload?

[mr-cheffy]

So, its pressing ctrl+W while ctrl+tabing, right?

[Vedaant-Rajoo]

Yup. That is correct. Its the short to unload/remove inside the Ctrl-Tab menu. You have to hold Ctrl while in the menu and just Press W on the tab you want to remove/unload. The bug was that during that session. An essential/pinned tab also got removed from the sidebar. (no matter what)

[mr-cheffy]

Sorry for the delay, i'll review ASAP when im free

[seongheum-choi]

There are conflicts. @Vedaant-Rajoo Would you mind if I fix this?
I've been wanting this fix.

[Vedaant-Rajoo]

Go ahead