Skip to content

[DEV-9741] Updated to support Vert.x v5 and its breaking changes. - #281

Merged
charlta merged 1 commit into
mainfrom
DEV-9741-update-graphql-vertx
Jul 29, 2026
Merged

[DEV-9741] Updated to support Vert.x v5 and its breaking changes.#281
charlta merged 1 commit into
mainfrom
DEV-9741-update-graphql-vertx

Conversation

@charlta

@charlta charlta commented Jul 29, 2026

Copy link
Copy Markdown
Member

Description

Updated support Vert.x v5. This required a rebuild of the auth route handlers to use the new Future paradigm.

We had also previously made a copy of the Vert.x auth handler rather than inheriting from it. This cause issues when they changed the visibility of some calls. To avoid future issues it is now correctly implemented using inheritance and overriding the appropriate functions for custom auth handling.

Associated tasks

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Vert.x v5 breaking changes

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@charlta
charlta marked this pull request as ready for review July 29, 2026 08:25
@charlta
charlta merged commit 7d0ab34 into main Jul 29, 2026
4 checks passed
@charlta
charlta deleted the DEV-9741-update-graphql-vertx branch July 29, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant