Fixed broken tests after kotlin version upgrade - #13
Merged
roberto-marquez merged 1 commit intoApr 9, 2026
Conversation
zarakay
approved these changes
Apr 9, 2026
zarakay
left a comment
Member
There was a problem hiding this comment.
How the hell did the CI go green?
roberto-marquez
force-pushed
the
fixed-broken-tests-after-kotlin-version-upgrade
branch
from
April 9, 2026 00:29
5d4e94f to
51b94d2
Compare
…ey fail without it. - Updated misc.xml to use JVM 17. Signed-off-by: Roberto Marquez <roberto.marquez@zepben.com>
roberto-marquez
force-pushed
the
fixed-broken-tests-after-kotlin-version-upgrade
branch
from
April 9, 2026 00:32
51b94d2 to
247cefb
Compare
Member
Author
It looks like the tests passed randomly without that static keyword. I think you just got lucky. |
roberto-marquez
deleted the
fixed-broken-tests-after-kotlin-version-upgrade
branch
April 9, 2026 00:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the upgrade kotlin/jvm version the tests were failing due to a missing keyword in SystemLogExtension usage.
This PR also updated the misc.xml to use JVM 17 instead of JVM 11.
Associated tasks
Test Steps
Clone the repo, copile and run the tests in maven. It will now work.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
- [ ] I have commented my code in any hard-to-understand or hacky areas.Security
When developing applications, use following guidelines for information security considerations:
Documentation
- [ ] I have updated the changelog.just fixed broken tests there's no changelog entry needed- [ ] I have updated any documentation required for these changes.just fixed broken tests there's no new doco neededBreaking Changes
Not breaking change.