Skip to content

Fixed broken tests after kotlin version upgrade - #13

Merged
roberto-marquez merged 1 commit into
mainfrom
fixed-broken-tests-after-kotlin-version-upgrade
Apr 9, 2026
Merged

Fixed broken tests after kotlin version upgrade#13
roberto-marquez merged 1 commit into
mainfrom
fixed-broken-tests-after-kotlin-version-upgrade

Conversation

@roberto-marquez

Copy link
Copy Markdown
Member

Description

After the upgrade kotlin/jvm version the tests were failing due to a missing keyword in SystemLogExtension usage.
This PR also updated the misc.xml to use JVM 17 instead of JVM 11.

Associated tasks

Test Steps

Clone the repo, copile and run the tests in maven. It will now work.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
    - [ ] I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

- [ ] I have updated the changelog. just fixed broken tests there's no changelog entry needed
- [ ] I have updated any documentation required for these changes. just fixed broken tests there's no new doco needed

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Not breaking change.

@roberto-marquez
roberto-marquez requested a review from zarakay April 9, 2026 00:22

@zarakay zarakay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the hell did the CI go green?

@roberto-marquez
roberto-marquez force-pushed the fixed-broken-tests-after-kotlin-version-upgrade branch from 5d4e94f to 51b94d2 Compare April 9, 2026 00:29
…ey fail without it.

- Updated misc.xml to use JVM 17.

Signed-off-by: Roberto Marquez <roberto.marquez@zepben.com>
@roberto-marquez
roberto-marquez force-pushed the fixed-broken-tests-after-kotlin-version-upgrade branch from 51b94d2 to 247cefb Compare April 9, 2026 00:32
@roberto-marquez

Copy link
Copy Markdown
Member Author

How the hell did the CI go green?

It looks like the tests passed randomly without that static keyword. I think you just got lucky.

@roberto-marquez
roberto-marquez merged commit 985b39f into main Apr 9, 2026
4 checks passed
@roberto-marquez
roberto-marquez deleted the fixed-broken-tests-after-kotlin-version-upgrade branch April 9, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants