Hook fix: Update toKernelPluginManager.ts#259
Open
maxsch-xmint wants to merge 4 commits intozerodevapp:mainfrom
Open
Hook fix: Update toKernelPluginManager.ts#259maxsch-xmint wants to merge 4 commits intozerodevapp:mainfrom
maxsch-xmint wants to merge 4 commits intozerodevapp:mainfrom
Conversation
Missing hook forwarding
encodeCalls unconditionally wraps calldata with executeUserOp when plugins?.hook is truthy, even during enable flow when the hook isn't installed yet. Fixed by checking isEnabled first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing hook forwarding in getPluginsEnableTypedDataV2