add elide transfers pass

.github/workflows/ci.yml

@@ -241,6 +241,12 @@ jobs:
     uses: ./.github/workflows/ci_linux_x64_clang_asan.yml
     secrets: inherit
 
+  windows_x64_msvc:
+    needs: setup
+    if: contains(fromJson(needs.setup.outputs.enabled-jobs), 'windows_x64_msvc')
+    uses: ./.github/workflows/ci_windows_x64_msvc.yml
+    secrets: inherit
+
   ##############################################################################
 
   # Aggregate job status and alerting on failures.
@@ -258,6 +264,7 @@ jobs:
       - linux_x64_bazel
       - linux_x64_clang
       - linux_x64_clang_asan
+      - windows_x64_msvc
     uses: ./.github/workflows/workflow_summary.yml
     secrets: inherit
     with:

.github/workflows/ci_windows_x64_msvc.yml

@@ -7,21 +7,11 @@
 name: CI - Windows x64 MSVC
 
 on:
-  schedule:
-    # Weekday mornings at 09:15 UTC = 01:15 PST (UTC - 8).
-    - cron: "15 9 * * 1-5"
+  workflow_call:
   workflow_dispatch:
 
-concurrency:
-  # A PR number if a pull request and otherwise the commit hash. This cancels
-  # queued and in-progress runs for the same PR (presubmit) or commit
-  # (postsubmit)
-  group: ${{ github.workflow }}-${{ github.event.number || github.sha }}
-  cancel-in-progress: true
-
 jobs:
   windows_x64_msvc:
-    if: ${{ github.repository_owner == 'iree-org' || github.event_name != 'schedule' }}
     runs-on: azure-windows-scale
     env:
       BASE_BUILD_DIR_POWERSHELL: B:\tmpbuild
@@ -34,6 +24,7 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           submodules: true
+      # TODO(#18813): Remove this. Environment setup needs to happen on runners, not in workflows.
       - name: "Create build dir"
         run: |
           $buildDir = "$env:BASE_BUILD_DIR_POWERSHELL\"
@@ -52,6 +43,8 @@ jobs:
           python3 -m venv .venv
           .venv/Scripts/activate.bat
           python3 -m pip install -r runtime/bindings/python/iree/runtime/build_requirements.txt
+      # TODO(#18813): Fix to actually use either ccache or sccache.
+      #               No need to install both, and neither is currently used.
       - name: "Installing requirements"
         run: choco install ccache --yes
       - name: "Configuring MSVC"
@@ -73,10 +66,4 @@ jobs:
         if: always()
         run: if (Test-Path -Path "$Env:BUILD_DIR_POWERSHELL") {Remove-Item -Path "$Env:BUILD_DIR_POWERSHELL" -Recurse -Force}
 
-      - name: Post to Discord on Failure
-        uses: sarisia/actions-status-discord@5ddd3b114a98457dd80a39b2f00b6a998cd69008 # v1.15.3
-        if: failure() && github.ref_name == 'main' && github.repository_owner == 'iree-org'
-        with:
-          webhook: ${{ secrets.DISCORD_WEBHOOK }}
-          description: "The ${{ github.workflow }} workflow failed"
-          url: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}/attempts/${{ github.run_attempt }}"
+      # Alerting on failure is the responsibility of the calling job.

.github/workflows/pkgci_test_pjrt.yml

@@ -30,14 +30,13 @@ jobs:
         include:
           - runner: ubuntu-24.04
             pjrt_platform: cpu
-        # TODO: cuda runner is not available yet, refer to #18814
-        #   - runner: some-cuda-available-runner
-        #     pjrt_platform: cuda
-        # TODO: enable these AMD runners
-        #   - runner: nodai-amdgpu-w7900-x86-64
-        #     pjrt_platform: rocm
-        #   - runner: nodai-amdgpu-w7900-x86-64
-        #     pjrt_platform: vulkan
+          - runner: ubuntu-24.04
+            pjrt_platform: cuda
+          # TODO: enable these AMD runners
+          # - runner: nodai-amdgpu-w7900-x86-64
+          #   pjrt_platform: rocm
+          # - runner: nodai-amdgpu-w7900-x86-64
+          #   pjrt_platform: vulkan
     name: Build and test
     runs-on: ${{ matrix.runner }}
     env:
@@ -76,8 +75,11 @@ jobs:
           export CMAKE_CXX_COMPILER_LAUNCHER=ccache
           python -m pip install -v --no-deps -e integrations/pjrt/python_packages/iree_${{ matrix.pjrt_platform }}_plugin
           # install
-          python -m pip install jax==0.4.36
+          python -m pip install jax==0.6.1
+      # TODO: We can only run on CPU for now, as the CUDA runner
+      # is not available yet, refer to #18814.
       - name: Run tests
+        if: ${{ matrix.pjrt_platform == 'cpu' }}
         run: |
           source ${VENV_DIR}/bin/activate
           build_tools/testing/run_jax_tests.sh ${{ matrix.pjrt_platform }}

.github/workflows/validate_and_publish_release.yml

@@ -23,7 +23,7 @@ jobs:
     steps:
       - name: Download packages
         id: download_packages
-        uses: dawidd6/action-download-artifact@07ab29fd4a977ae4d2b275087cf67563dfdf0295 # v9
+        uses: dawidd6/action-download-artifact@4c1e823582f43b179e2cbb49c3eade4e41f992e2 # v10
         with:
           github_token: ${{secrets.WRITE_ACCESS_TOKEN}}
           workflow: build_package.yml

README.md

@@ -51,7 +51,6 @@ https://iree.dev/developers/general/release-management/.
 Linux | [![CI - Linux arm64 clang](https://github.com/iree-org/iree/actions/workflows/ci_linux_arm64_clang.yml/badge.svg?query=branch%3Amain+event%3Aschedule)](https://github.com/iree-org/iree/actions/workflows/ci_linux_arm64_clang.yml?query=branch%3Amain+event%3Aschedule)
 macOS | [![CI - macOS x64 clang](https://github.com/iree-org/iree/actions/workflows/ci_macos_x64_clang.yml/badge.svg?query=branch%3Amain+event%3Aschedule)](https://github.com/iree-org/iree/actions/workflows/ci_macos_x64_clang.yml?query=branch%3Amain+event%3Aschedule)
 macOS | [![CI - macOS arm64 clang](https://github.com/iree-org/iree/actions/workflows/ci_macos_arm64_clang.yml/badge.svg?query=branch%3Amain+event%3Aschedule)](https://github.com/iree-org/iree/actions/workflows/ci_macos_arm64_clang.yml?query=branch%3Amain+event%3Aschedule)
-Windows | [![CI - Windows x64 MSVC](https://github.com/iree-org/iree/actions/workflows/ci_windows_x64_msvc.yml/badge.svg?query=branch%3Amain+event%3Aschedule)](https://github.com/iree-org/iree/actions/workflows/ci_windows_x64_msvc.yml?query=branch%3Amain+event%3Aschedule)
 
 For the full list of workflows see
 https://iree.dev/developers/general/github-actions/.

build_tools/github_actions/configure_ci.py

@@ -119,6 +119,7 @@ def contains(cls, val):
 DEFAULT_POSTSUBMIT_ONLY_JOBS = frozenset(
     [
         # None.
+        "windows_x64_msvc",
     ]
 )
 
@@ -128,7 +129,10 @@ def contains(cls, val):
 #   ("test_nvidia_a100", ["compiler/plugins/target/CUDA/*"]),
 # Note: these jobs should also be included in DEFAULT_POSTSUBMIT_ONLY_JOBS.
 PRESUBMIT_TOUCH_ONLY_JOBS = [
-    # None.
+    (
+        "windows_x64_msvc",
+        ["*win32*", "*windows*", "*msvc*"],
+    ),
 ]
 
 PR_DESCRIPTION_TEMPLATE = string.Template("${title}\n\n${body}")

build_tools/github_actions/configure_ci_test.py

@@ -64,7 +64,6 @@ def test_get_enabled_jobs_all(self):
         )
         self.assertCountEqual(jobs, all_jobs)
 
-    @unittest.skip("skipped while there are no postsubmit only jobs")
     def test_get_enabled_jobs_postsubmit(self):
         trailers = {}
         default_jobs = {"job1", "job2", "job3"}
@@ -82,7 +81,6 @@ def test_get_enabled_jobs_postsubmit(self):
         )
         self.assertCountEqual(jobs, all_jobs)
 
-    @unittest.skip("skipped while there are no postsubmit only jobs")
     def test_get_enabled_jobs_no_postsubmit(self):
         trailers = {}
         default_jobs = {"job1", "job2", "job3"}
@@ -100,7 +98,6 @@ def test_get_enabled_jobs_no_postsubmit(self):
         )
         self.assertCountEqual(jobs, default_jobs)
 
-    @unittest.skip("skipped while there are no postsubmit only jobs")
     def test_get_enabled_jobs_llvm_integrate(self):
         trailers = {}
         default_jobs = {"job1", "job2", "job3"}
@@ -118,7 +115,6 @@ def test_get_enabled_jobs_llvm_integrate(self):
         )
         self.assertCountEqual(jobs, all_jobs)
 
-    @unittest.skip("skipped while there are no postsubmit only jobs")
     def test_get_enabled_jobs_no_modifies(self):
         trailers = {}
         default_jobs = {"job1", "job2", "job3"}
@@ -136,7 +132,6 @@ def test_get_enabled_jobs_no_modifies(self):
         )
         self.assertCountEqual(jobs, {})
 
-    @unittest.skip("skipped while there are no postsubmit only jobs")
     def test_get_enabled_jobs_skip(self):
         trailers = {configure_ci.Trailer.SKIP_JOBS: "job1,job2"}
         default_jobs = {"job1", "job2", "job3"}
@@ -154,7 +149,6 @@ def test_get_enabled_jobs_skip(self):
         )
         self.assertCountEqual(jobs, {"job3"})
 
-    @unittest.skip("skipped while there are no postsubmit only jobs")
     def test_get_enabled_jobs_skip_all(self):
         trailers = {configure_ci.Trailer.SKIP_JOBS: "all"}
         default_jobs = {"job1", "job2", "job3"}
@@ -172,7 +166,6 @@ def test_get_enabled_jobs_skip_all(self):
         )
         self.assertCountEqual(jobs, {})
 
-    @unittest.skip("skipped while there are no postsubmit only jobs")
     def test_get_enabled_jobs_extra(self):
         postsubmit_job = next(iter(configure_ci.DEFAULT_POSTSUBMIT_ONLY_JOBS))
         trailers = {configure_ci.Trailer.EXTRA_JOBS: postsubmit_job}
@@ -190,7 +183,6 @@ def test_get_enabled_jobs_extra(self):
         )
         self.assertCountEqual(jobs, all_jobs)
 
-    @unittest.skip("skipped while there are no postsubmit only jobs")
     def test_get_enabled_jobs_exactly(self):
         postsubmit_job = next(iter(configure_ci.DEFAULT_POSTSUBMIT_ONLY_JOBS))
         trailers = {configure_ci.Trailer.EXACTLY_JOBS: postsubmit_job}
@@ -208,6 +200,39 @@ def test_get_enabled_jobs_exactly(self):
         )
         self.assertCountEqual(jobs, {postsubmit_job})
 
+    def test_get_enabled_jobs_windows(self):
+        trailers = {}
+        all_jobs = {"job1"}
+        is_pr = True
+        is_llvm_integrate_pr = False
+        modified_paths = ["runtime/src/iree/base/internal/threading_win32.c"]
+        jobs = configure_ci.get_enabled_jobs(
+            trailers,
+            all_jobs,
+            modified_paths=modified_paths,
+            is_pr=is_pr,
+            is_llvm_integrate_pr=is_llvm_integrate_pr,
+        )
+        expected_jobs = {"job1", "windows_x64_msvc"}
+        self.assertCountEqual(jobs, expected_jobs)
+
+    def test_get_enabled_jobs_windows_docs(self):
+        # docs/ directory is excluded from CI, superceding "windows" inclusion
+        trailers = {}
+        all_jobs = {"job1"}
+        is_pr = True
+        is_llvm_integrate_pr = False
+        modified_paths = ["docs/windows.md"]
+        jobs = configure_ci.get_enabled_jobs(
+            trailers,
+            all_jobs,
+            modified_paths=modified_paths,
+            is_pr=is_pr,
+            is_llvm_integrate_pr=is_llvm_integrate_pr,
+        )
+        expected_jobs = {}
+        self.assertCountEqual(jobs, expected_jobs)
+
     def test_parse_path_from_workflow_ref(self):
         path = configure_ci.parse_path_from_workflow_ref(
             "octocat/example", "octocat/example/.github/test.yml@1234"

compiler/plugins/target/ROCM/BUILD.bazel

@@ -27,7 +27,7 @@ iree_compiler_cc_library(
         "ROCMTargetUtils.h",
     ],
     deps = [
-        "//compiler/plugins/target/ROCM/builtins/tuning:iree_default_tuning_specs_amdgpu",
+        "//compiler/plugins/target/ROCM/Dialect/ROCM/IR:ROCMDialect",
         "//compiler/plugins/target/ROCM/builtins/ukernel:iree_uk_amdgpu_bitcode",
         "//compiler/src/iree/compiler/Codegen/Common",
         "//compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR:IREECodegenDialect",

compiler/plugins/target/ROCM/CMakeLists.txt

@@ -66,7 +66,7 @@ iree_cc_library(
     iree::compiler::Dialect::HAL::Utils::LLVMLinkerUtils
     iree::compiler::PluginAPI
     iree::compiler::Utils
-    iree::compiler::plugins::target::ROCM::builtins::tuning::iree_default_tuning_specs_amdgpu
+    iree::compiler::plugins::target::ROCM::Dialect::ROCM::IR::ROCMDialect
     iree::compiler::plugins::target::ROCM::builtins::ukernel::iree_uk_amdgpu_bitcode
     iree::schemas::amdgpu_executable_def_c_fbs
     iree::schemas::executable_debug_info_c_fbs

compiler/plugins/target/ROCM/Dialect/BUILD.bazel

@@ -0,0 +1,11 @@
+# Copyright 2025 The IREE Authors
+#
+# Licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(
+    default_visibility = ["//visibility:public"],
+    features = ["layering_check"],
+    licenses = ["notice"],  # Apache 2.0
+)

compiler/plugins/target/ROCM/Dialect/CMakeLists.txt

@@ -0,0 +1,13 @@
+################################################################################
+# Autogenerated by build_tools/bazel_to_cmake/bazel_to_cmake.py from           #
+# compiler/plugins/target/ROCM/Dialect/BUILD.bazel                             #
+#                                                                              #
+# Use iree_cmake_extra_content from iree/build_defs.oss.bzl to add arbitrary   #
+# CMake-only content.                                                          #
+#                                                                              #
+# To disable autogeneration for this file entirely, delete this header.        #
+################################################################################
+
+iree_add_all_subdirs()
+
+### BAZEL_TO_CMAKE_PRESERVES_ALL_CONTENT_BELOW_THIS_LINE ###

compiler/plugins/target/ROCM/Dialect/ROCM/BUILD.bazel

@@ -0,0 +1,11 @@
+# Copyright 2025 The IREE Authors
+#
+# Licensed under the Apache License v2.0 with LLVM Exceptions.
+# See https://llvm.org/LICENSE.txt for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+package(
+    default_visibility = ["//visibility:public"],
+    features = ["layering_check"],
+    licenses = ["notice"],  # Apache 2.0
+)

compiler/plugins/target/ROCM/Dialect/ROCM/CMakeLists.txt

@@ -0,0 +1,13 @@
+################################################################################
+# Autogenerated by build_tools/bazel_to_cmake/bazel_to_cmake.py from           #
+# compiler/plugins/target/ROCM/Dialect/ROCM/BUILD.bazel                        #
+#                                                                              #
+# Use iree_cmake_extra_content from iree/build_defs.oss.bzl to add arbitrary   #
+# CMake-only content.                                                          #
+#                                                                              #
+# To disable autogeneration for this file entirely, delete this header.        #
+################################################################################
+
+iree_add_all_subdirs()
+
+### BAZEL_TO_CMAKE_PRESERVES_ALL_CONTENT_BELOW_THIS_LINE ###