Hal resolve memory properties

.github/workflows/build_package.yml

@@ -122,23 +122,23 @@ jobs:
             build-family: linux-x86_64
             build-package: main-dist-linux
             experimental: false
-          - runs-on: ah-ubuntu_22_04-c7g_4x-50
+          - runs-on: ubuntu-24.04-arm
             build-family: linux-aarch64
             build-package: main-dist-linux
             experimental: true
           - runs-on: ubuntu-24.04
             build-family: linux-x86_64
             build-package: py-compiler-pkg
             experimental: false
-          - runs-on: ah-ubuntu_22_04-c7g_4x-50
+          - runs-on: ubuntu-24.04-arm
             build-family: linux-aarch64
             build-package: py-compiler-pkg
             experimental: true
           - runs-on: ubuntu-24.04
             build-family: linux-x86_64
             build-package: py-runtime-pkg
             experimental: false
-          - runs-on: ah-ubuntu_22_04-c7g_4x-50
+          - runs-on: ubuntu-24.04-arm
             build-family: linux-aarch64
             build-package: py-runtime-pkg
             experimental: true
@@ -168,11 +168,11 @@ jobs:
           - runs-on: windows-2022
             build-family: windows
             build-package: py-compiler-pkg
-            experimental: true
+            experimental: false
           - runs-on: windows-2022
             build-family: windows
             build-package: py-runtime-pkg
-            experimental: true
+            experimental: false
 
     env:
       # These are also set in: build_tools/python_deploy/build_linux_packages.sh

.github/workflows/ci_windows_x64_msvc.yml

@@ -53,7 +53,9 @@ jobs:
         run: |
           choco install sccache
           choco install cmake
-          choco install ninja
+          # ninja pinned due to a bug in the 1.13.0 release:
+          # https://github.com/ninja-build/ninja/issues/2616
+          choco install ninja --version 1.12.1
           Import-Module $env:ChocolateyInstall\helpers\chocolateyProfile.psm1
           refreshenv
       - name: "Building IREE"

.github/workflows/oneshot_candidate_release.yml

@@ -70,7 +70,7 @@ jobs:
 
       - name: Create Release
         id: create_release
-        uses: ncipollo/release-action@440c8c1cb0ed28b9f43e4d1d670870f059653174 # v1.16.0
+        uses: ncipollo/release-action@bcfe5470707e8832e12347755757cec0eb3c22af # v1.18.0
         with:
           tag: ${{ env.tag_name }}
           name: iree candidate ${{ env.tag_name }}

.github/workflows/schedule_candidate_release.yml

@@ -66,7 +66,7 @@ jobs:
 
       - name: Create Release
         id: create_release
-        uses: ncipollo/release-action@440c8c1cb0ed28b9f43e4d1d670870f059653174 # v1.16.0
+        uses: ncipollo/release-action@bcfe5470707e8832e12347755757cec0eb3c22af # v1.18.0
         with:
           tag: ${{ env.tag_name }}
           name: iree candidate ${{ env.tag_name }}

.github/workflows/validate_and_publish_release.yml

@@ -23,7 +23,7 @@ jobs:
     steps:
       - name: Download packages
         id: download_packages
-        uses: dawidd6/action-download-artifact@4c1e823582f43b179e2cbb49c3eade4e41f992e2 # v10
+        uses: dawidd6/action-download-artifact@ac66b43f0e6a346234dd65d4d0c8fbb31cb316e5 # v11
         with:
           github_token: ${{secrets.WRITE_ACCESS_TOKEN}}
           workflow: build_package.yml

CMakeLists.txt

@@ -530,10 +530,22 @@ if(IREE_ENABLE_CCACHE)
   endif()
 endif()
 
-set (CMAKE_POSITION_INDEPENDENT_CODE ${IREE_ENABLE_POSITION_INDEPENDENT_CODE})
+set(CMAKE_POSITION_INDEPENDENT_CODE ${IREE_ENABLE_POSITION_INDEPENDENT_CODE})
 
 option(IREE_DEV_MODE "Configure settings to optimize for IREE development (as opposed to CI or release)" OFF)
 
+option(IREE_ENABLE_RUNTIME_COVERAGE "Enable LLVM code coverage of the runtime" OFF)
+set(IREE_RUNTIME_COVERAGE_OBJECTS "" CACHE STRING "List of archives (.a), objects (.o), or binaries to use as coverage data sources.")
+set_property(GLOBAL PROPERTY IREE_RUNTIME_COVERAGE_TARGETS "")
+
+# Verify we are in debug mode (coverage doesn't work well without it).
+# Coverage is possible (though very inaccurate) in other configurations but
+# optimizations must be disabled to get anything useful (otherwise source lines
+# and instrumented execution don't line up enough).
+if(IREE_ENABLE_RUNTIME_COVERAGE AND NOT _UPPERCASE_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
+  message(FATAL_ERROR "IREE_ENABLE_*_COVERAGE requires building in Debug")
+endif()
+
 #-------------------------------------------------------------------------------
 # IREE assertions
 # We don't love the way this is done, but we have to line it up with how LLVM
@@ -1112,6 +1124,99 @@ if(IREE_BUILD_TESTS)
   iree_create_ctest_customization()
 endif()
 
+#-------------------------------------------------------------------------------
+# Code coverage support
+#-------------------------------------------------------------------------------
+
+# LLVM coverage targets:
+#
+# - iree-runtime-coverage-export
+#   Merge and export coverage data to `coverage/runtime.lcov.info`.
+#   All of `coverage/runtime/*.profraw` files will be merged as if they had been
+#   produced in the same run, written to `coverage/runtime.profdata`, and then
+#   exported into LCOV format.
+#
+# - iree-runtime-coverage-clear-all
+#   Erases all `coverage/runtime*` files (*.profraw/*.profdata/*.info).
+#   Invoke this to completely clear all collected coverage data.
+#
+# - iree-runtime-coverage-clear-artifacts
+#   Erases only merged `coverage/runtime.*` files (*.profdata/*.info).
+#   Invoke this after adding more *.profraw files to update the coverage.
+#
+# To collect the source *.profraw files use the LLVM_PROFILE_FILE environment
+# variable on each invocation; tests run via ctest do this automatically:
+#  LLVM_PROFILE_FILE=coverage/runtime/binary_target_name[.whatever].profraw \
+#     my_binary_to_run --other --flags
+# The base name before the first `.` must be the target name for the tooling to
+# automatically detect the binaries used. Any additional `.foo` up to the
+# extension will be ignored and allow for multiple runs to be accumulated before
+# exporting. If the name is not target-name based then the
+# IREE_RUNTIME_COVERAGE_OBJECTS CMake variable must be populated with binaries,
+# archives (.a), or object files (.o).
+#
+# VSCode can be configured with these targets/artifacts to show coverage
+# information by adding the following workspace configuration:
+#   // Accumulate over multiple test runs:
+#   "cmake.preRunCoverageTarget": "iree-runtime-coverage-clear-artifacts",
+#   // Or only show coverage for the tests run in a single batch:
+#   "cmake.preRunCoverageTarget": "iree-runtime-coverage-clear-all",
+#   "cmake.postRunCoverageTarget": "iree-runtime-coverage-export",
+#   "cmake.coverageInfoFiles": [
+#     "${command:cmake.buildDirectory}/coverage/runtime.lcov.info"
+#  ],
+if(IREE_ENABLE_RUNTIME_COVERAGE)
+  set(_RUNTIME_COVERAGE_BASE "${IREE_BINARY_DIR}/coverage/runtime")
+  if(Python3_FOUND)
+    get_property(_RUNTIME_COVERAGE_TARGETS GLOBAL PROPERTY IREE_RUNTIME_COVERAGE_TARGETS)
+    file(GENERATE
+      OUTPUT
+        ${_RUNTIME_COVERAGE_BASE}.target.list
+      CONTENT
+        "${_RUNTIME_COVERAGE_TARGETS}"
+    )
+    add_custom_target(iree-runtime-coverage-export
+      COMMAND
+        ${Python3_EXECUTABLE}
+        ${IREE_ROOT_DIR}/build_tools/scripts/export_profdata_lcov.py
+        --base=${_RUNTIME_COVERAGE_BASE}
+        --objects=${IREE_RUNTIME_COVERAGE_OBJECTS}
+        --targets=${_RUNTIME_COVERAGE_BASE}.target.list
+        --output=${_RUNTIME_COVERAGE_BASE}.lcov.info
+        --llvm-profdata=${IREE_LLVM_PROFDATA_BINARY}
+        --llvm-cov=${IREE_LLVM_COV_BINARY}
+      BYPRODUCTS
+        ${_RUNTIME_COVERAGE_BASE}.lcov.info
+      DEPENDS
+        ${IREE_LLVM_COV_BINARY}
+        ${IREE_LLVM_PROFCOV_BINARY}
+      COMMENT
+        "Exporting runtime coverage data to ${_RUNTIME_COVERAGE_BASE}.lcov.info"
+    )
+  else()
+    message(WARNING "IREE_ENABLE_*_COVERAGE requires Python3 to export automatically via the iree-runtime-coverage-export target; coverage is still enabled but must be manually processed")
+  endif()
+  add_custom_target(iree-runtime-coverage-clear-all
+    COMMAND
+      ${CMAKE_COMMAND}
+      -E rm -f
+      "${_RUNTIME_COVERAGE_BASE}.profdata"
+      "${_RUNTIME_COVERAGE_BASE}.lcov.info"
+      "${_RUNTIME_COVERAGE_BASE}/*.profraw"
+    COMMENT
+      "Clearing ${_RUNTIME_COVERAGE_BASE}/* and related source coverage data"
+  )
+  add_custom_target(iree-runtime-coverage-clear-artifacts
+    COMMAND
+      ${CMAKE_COMMAND}
+      -E rm -f
+      "${_RUNTIME_COVERAGE_BASE}.profdata"
+      "${_RUNTIME_COVERAGE_BASE}.lcov.info"
+    COMMENT
+      "Clearing merged ${_RUNTIME_COVERAGE_BASE}.* files only"
+  )
+endif(IREE_ENABLE_RUNTIME_COVERAGE)
+
 #-------------------------------------------------------------------------------
 # Install/exports
 # Note that with no further options, install convenience targets install to

README.md

@@ -89,8 +89,10 @@ Community meeting recordings: [IREE YouTube channel](https://www.youtube.com/@ir
 
 Date | Title | Recording | Slides
 ---- | ----- | --------- | ------
+2025-06-10 | Data-Tiling in IREE: Achieving High Performance Through Compiler Design (AsiaLLVM) | [recording](https://www.youtube.com/watch?v=iANJWUL_SOo) | [slides](https://llvm.org/devmtg/2025-06/slides/technical-talk/wang-data-tilling.pdf)
+2025-05-17 | Introduction to GPU architecture and IREE's GPU CodeGen Pipeline | [recording](https://www.youtube.com/watch?v=9Fy2jxj0ARE) | [slides](https://drive.google.com/file/d/1xbABUy3kQxxBzOUb3WjBOFCSY_sQYdGo/view)
 2025-02-12 | The Long Tail of AI: SPIR-V in IREE and MLIR (Vulkanised) | [recording](https://youtu.be/0zwfc6UkxeE) | [slides](https://www.vulkan.org/user/pages/09.events/vulkanised-2025/T12-Jakub-Kuderski-AMD-IREE-MLIR.pdf)
-2024-10-01 | Unveiling the Inner Workings of IREE: An MLIR-Based Compiler for Diverse H/W | [recording](https://www.youtube.com/watch?v=a3T74I9gGH8) |
+2024-10-01 | Unveiling the Inner Workings of IREE: An MLIR-Based Compiler for Diverse Hardware | [recording](https://www.youtube.com/watch?v=a3T74I9gGH8) |
 2021-06-09 | IREE Runtime Design Tech Talk | [recording](https://drive.google.com/file/d/1p0DcysaIg8rC7ErKYEgutQkOJGPFCU3s/view) | [slides](https://drive.google.com/file/d/1ikgOdZxnMz1ExqwrAiuTY9exbe3yMWbB/view?usp=sharing)
 2020-08-20 | IREE CodeGen (MLIR Open Design Meeting) | [recording](https://drive.google.com/file/d/1325zKXnNIXGw3cdWrDWJ1-bp952wvC6W/view?usp=sharing) | [slides](https://docs.google.com/presentation/d/1NetHjKAOYg49KixY5tELqFp6Zr2v8_ujGzWZ_3xvqC8/edit)
 2020-03-18 | Interactive HAL IR Walkthrough | [recording](https://drive.google.com/file/d/1_sWDgAPDfrGQZdxAapSA90AD1jVfhp-f/view?usp=sharing) |

build_tools/bazel/build_defs.oss.bzl

@@ -138,7 +138,7 @@ def iree_runtime_cc_library(deps = [], **kwargs):
         **kwargs
     )
 
-def iree_runtime_cc_test(deps = [], **kwargs):
+def iree_runtime_cc_test(deps = [], group = None, **kwargs):
     """Used for cc_test targets within the //runtime tree.
 
     This is a pass-through to the native cc_test which adds specific

build_tools/bazel_to_cmake/bazel_to_cmake_converter.py

@@ -460,6 +460,7 @@ def cc_test(
         args=None,
         tags=None,
         includes=None,
+        group=None,
         **kwargs,
     ):
         if self._should_skip_target(tags=tags, **kwargs):
@@ -475,6 +476,7 @@ def cc_test(
         labels_block = self._convert_string_list_block("LABELS", tags)
         timeout_block = self._convert_timeout_arg_block("TIMEOUT", timeout)
         includes_block = self._convert_includes_block(includes)
+        group_block = self._convert_string_arg_block("GROUP", group)
 
         self._converter.body += (
             f"iree_cc_test(\n"
@@ -489,6 +491,7 @@ def cc_test(
             f"{labels_block}"
             f"{timeout_block}"
             f"{includes_block}"
+            f"{group_block}"
             f")\n\n"
         )
 

build_tools/cmake/iree_cc_binary.cmake

@@ -23,6 +23,7 @@
 # LINKOPTS: List of link options
 # TESTONLY: for testing; won't compile when tests are disabled
 # HOSTONLY: host only; compile using host toolchain when cross-compiling
+# COVERAGE: whether to enable code coverage during compilation/linking.
 # SETUP_INSTALL_RPATH: Sets an install RPATH which assumes the standard
 #   directory layout (to be used if linking against installed shared libs).
 # INSTALL_COMPONENT: CMake install component (Defaults to "IREETool-${_RULE_NAME}").
@@ -53,7 +54,7 @@ function(iree_cc_binary)
   cmake_parse_arguments(
     _RULE
     "EXCLUDE_FROM_ALL;HOSTONLY;TESTONLY;SETUP_INSTALL_RPATH;DISABLE_LLVM_LINK_LLVM_DYLIB"
-    "NAME;INSTALL_COMPONENT"
+    "NAME;INSTALL_COMPONENT;COVERAGE"
     "SRCS;COPTS;DEFINES;LINKOPTS;DATA;DEPS"
     ${ARGN}
   )
@@ -131,6 +132,21 @@ function(iree_cc_binary)
       ${_RULE_LINKOPTS}
   )
 
+  # Enable coverage if requested.
+  if(${_RULE_COVERAGE})
+    target_compile_options(${_NAME}
+      PRIVATE
+        "-fprofile-instr-generate"
+        "-fcoverage-mapping"
+    )
+    target_link_options(${_NAME}
+      PRIVATE
+        "-fprofile-instr-generate"
+        "-fcoverage-mapping"
+    )
+    set_property(GLOBAL APPEND PROPERTY IREE_RUNTIME_COVERAGE_TARGETS "${_NAME}=$<TARGET_FILE:${_NAME}>")
+  endif()
+
   # Replace dependencies passed by ::name with iree::package::name
   list(TRANSFORM _RULE_DEPS REPLACE "^::" "${_PACKAGE_NS}::")
   if(NOT _RULE_DISABLE_LLVM_LINK_LLVM_DYLIB)

build_tools/cmake/iree_cc_test.cmake

@@ -15,12 +15,13 @@
 #     Note: flag passing is only enforced through CTest, so manually running
 #     the test binaries (such as under a debugger) will _not_ pass any
 #     arguments without extra setup.
-# SRCS: List of source files for the binary
-# DATA: List of other targets and files required for this binary
-# DEPS: List of other libraries to be linked in to the binary targets
-# COPTS: List of private compile options
-# DEFINES: List of public defines
-# LINKOPTS: List of link options
+# SRCS: List of source files for the binary.
+# DATA: List of other targets and files required for this binary.
+# DEPS: List of other libraries to be linked in to the binary targets.
+# COPTS: List of private compile options.
+# DEFINES: List of public defines.
+# LINKOPTS: List of link options.
+# GROUP: Optional test group to add the target to.
 # LABELS: Additional labels to apply to the test. The package path is added
 #     automatically.
 #
@@ -58,7 +59,7 @@ function(iree_cc_test)
     _RULE
     ""
     "NAME"
-    "ARGS;SRCS;COPTS;DEFINES;LINKOPTS;DATA;DEPS;LABELS;TIMEOUT"
+    "ARGS;SRCS;COPTS;DEFINES;LINKOPTS;DATA;DEPS;LABELS;GROUP;TIMEOUT"
     ${ARGN}
   )
 
@@ -137,6 +138,8 @@ function(iree_cc_test)
   string(REPLACE "::" "/" _PACKAGE_PATH ${_PACKAGE_NS})
   set(_NAME_PATH "${_PACKAGE_PATH}/${_RULE_NAME}")
 
+  set(_ENVIRONMENT_VARS)
+
   # Case for cross-compiling towards Android.
   if(ANDROID)
     set(_ANDROID_REL_DIR "${_PACKAGE_PATH}/${_RULE_NAME}")
@@ -155,13 +158,9 @@ function(iree_cc_test)
     # Use environment variables to instruct the script to push artifacts
     # onto the Android device before running the test. This needs to match
     # with the expectation of the run_android_test.{sh|bat|ps1} script.
-    set(
-      _ENVIRONMENT_VARS
-        TEST_ANDROID_ABS_DIR=${_ANDROID_ABS_DIR}
-        TEST_EXECUTABLE=$<TARGET_FILE:${_NAME}>
-        TEST_TMPDIR=${_ANDROID_ABS_DIR}/test_tmpdir
-    )
-    set_property(TEST ${_NAME_PATH} PROPERTY ENVIRONMENT ${_ENVIRONMENT_VARS})
+    list(APPEND _ENVIRONMENT_VARS TEST_ANDROID_ABS_DIR=${_ANDROID_ABS_DIR})
+    list(APPEND _ENVIRONMENT_VARS TEST_EXECUTABLE=$<TARGET_FILE:${_NAME}>)
+    list(APPEND _ENVIRONMENT_VARS TEST_TMPDIR=${_ANDROID_ABS_DIR}/test_tmpdir)
   elseif((IREE_ARCH STREQUAL "riscv_64" OR
           IREE_ARCH STREQUAL "riscv_32") AND
          CMAKE_SYSTEM_NAME STREQUAL "Linux")
@@ -188,11 +187,32 @@ function(iree_cc_test)
     iree_configure_test(${_NAME_PATH})
   endif(ANDROID)
 
-  if (NOT DEFINED _RULE_TIMEOUT)
+  # TODO(benvanik): add an iree_runtime_cc_test that wraps this and adds the
+  # runtime-specific options. Today all tests use iree_cc_test, but since this
+  # is harmless for non-instrumented tests it's safe to apply to a bit more than
+  # we intend.
+  if(IREE_ENABLE_RUNTIME_COVERAGE)
+    list(APPEND _ENVIRONMENT_VARS LLVM_PROFILE_FILE=${IREE_BINARY_DIR}/coverage/runtime/${_NAME}.profraw)
+    set_property(GLOBAL APPEND PROPERTY IREE_RUNTIME_COVERAGE_TARGETS "${_NAME}=$<TARGET_FILE:${_NAME}>")
+  endif()
+
+  set_property(TEST ${_NAME_PATH} APPEND PROPERTY ENVIRONMENT ${_ENVIRONMENT_VARS})
+
+  if(NOT DEFINED _RULE_TIMEOUT)
     set(_RULE_TIMEOUT 60)
   endif()
 
   list(APPEND _RULE_LABELS "${_PACKAGE_PATH}")
   set_property(TEST ${_NAME_PATH} PROPERTY LABELS "${_RULE_LABELS}")
   set_property(TEST ${_NAME_PATH} PROPERTY TIMEOUT ${_RULE_TIMEOUT})
+
+  if(_RULE_GROUP)
+    if(NOT TARGET ${_RULE_GROUP})
+      add_custom_target(${_RULE_GROUP}
+        COMMENT
+          "Building IREE unit tests for ${_RULE_GROUP}"
+      )
+    endif()
+    add_dependencies(${_RULE_GROUP} "${_NAME}")
+  endif()
 endfunction()