Skip to content

Explicitly disable source routing if it is not enabled - #676

Merged
puddly merged 3 commits into
zigpy:devfrom
puddly:puddly/explicitly-disable-source-routing
Jun 23, 2025
Merged

Explicitly disable source routing if it is not enabled#676
puddly merged 3 commits into
zigpy:devfrom
puddly:puddly/explicitly-disable-source-routing

Conversation

@puddly

@puddly puddly commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

I noticed when testing EmberZNet 7.5.5.0 that source routing magically got enabled on my network by default. This is something we need to explicitly disable before releasing newer firmware updates.

@puddly
puddly merged commit 81e25be into zigpy:dev Jun 23, 2025
12 checks passed
@codecov

codecov Bot commented Jun 23, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.44%. Comparing base (9f002c4) to head (96260a9).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
bellows/zigbee/application.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #676   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          52       52           
  Lines        3764     3769    +5     
=======================================
+ Hits         3743     3748    +5     
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mineshaftgap pushed a commit to mineshaftgap/bellows that referenced this pull request Jun 11, 2026
* Explicitly disable source routing if it is not enabled

* Add a unit test

* Fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant