Allow any reset during startup, not just RESET_SOFTWARE - #694
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #694 +/- ##
==========================================
+ Coverage 99.52% 99.54% +0.02%
==========================================
Files 58 58
Lines 3971 3975 +4
==========================================
+ Hits 3952 3957 +5
+ Misses 19 18 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
approved these changes
Oct 24, 2025
|
I've tried this performing 80 upgrades in a loop using a script that previously reproduced the occasional failure (previously 3-10 failures when tried 80times). With this PR, I got 0 failures on 80 retries. |
puddly
force-pushed
the
puddly/allow-any-reset
branch
from
October 27, 2025 13:51
0d0316b to
8b1da34
Compare
mineshaftgap
pushed a commit
to mineshaftgap/bellows
that referenced
this pull request
Jun 11, 2026
* Allow any reset during startup, not just `RESET_SOFTWARE` * Attempt to reset multiple times * Reduce reset timeout * Deal with spurious resets better * Update unit tests to account for five retries on connect * Add some tests * Bump default Python version to 3.11.14 * Drop default Python version * Drop `PRE_COMMIT_CACHE_PATH`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RESET_POWER_ONRESET_WATCHDOGBoth of these indicate that the firmware has fully reset, we don't actually need to care about why it reset and our current restriction to accepting only
RESET_SOFTWAREas a valid reason causes bellows to fail to start up in cases where it can continue without any issues.