Epehemral pvc fix - #301
Open
thegooddayo wants to merge 6 commits into
Open
thegooddayo wants to merge 6 commits into
thegooddayo wants to merge 6 commits into
Conversation
Upgrade Milvus
Adds persistentVolumeClaim.ephemeral (default false) to both standalone.persistence and log.persistence. When true, pods use a generic ephemeral volume (inline PVC bound to the pod lifecycle) instead of a named PersistentVolumeClaim. Requires Kubernetes >= 1.21. Precedence: existingClaim > ephemeral > default named PVC. If both existingClaim and ephemeral are set, existingClaim wins -- consistent with how pvc.yaml already gates PVC creation on (not existingClaim). Defaults preserve existing behavior; default render is byte-identical to master. Upstream (zilliztech/milvus-helm at 5.0.22 / Milvus 2.6.18) does not have this option. - new helpers: milvus.logVolume, milvus.standaloneDataVolume - pvc.yaml skips named PVC creation when ephemeral=true and no existingClaim - all 11 deployment templates emit the helper-rendered volume entry Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thegooddayo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])