Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: chyezh <chyezh@outlook.com>
QA Verification SummaryI verified this PR in the What was validated
Runtime examples verified:
Proxy and DataNode were also split into separate AZ-style deployment groups with independent labels and env vars. Blue-green flow verifiedI validated a multi-replica to multi-replica blue-green flow. Runtime load and streaming settings were changed through etcd dynamic config, not through Sequence:
Final state:
Workload resultA continuous search/query workload ran through baseline, overlap expansion, dynamic config switch, green cutover, and old deployment removal. Final workload summary: {"count": 1860, "errors": 0, "elapsed": 467.11}Error log: No serviceability or routing errors were observed, including:
Compatibility checkI also checked the old paths:
I added a documentation update to clarify that |
Signed-off-by: chyezh <chyezh@outlook.com>
2f6daef to
d39d820
Compare
| # Optional deployment groups. When set, one Deployment is rendered per group. | ||
| # Group-level replicas, labels, annotations, extraEnv, nodeSelector, affinity, | ||
| # tolerations, and topologySpreadConstraints override or extend this component. | ||
| groups: [] |
There was a problem hiding this comment.
Could the relationship between replicaResourceGroups and groups be documented? It would be good to state this explicitly in the guide / values comments.
What this PR does / why we need it:
This PR adds generic deployment group support for selected Milvus components so operators can split workloads into multiple Kubernetes Deployments, for example by availability zone or other user-defined labels.
Changes included:
groupssupport for Proxy, DataNode, QueryNode, and StreamingNode.milvus.io/deployment-groupselector label to avoid overlapping Deployment selectors.replicas,labels,annotations,extraEnv,nodeSelector,affinity,tolerations, andtopologySpreadConstraints.replicaResourceGroupspath compatible for QueryNode and StreamingNode.extraEnv.Validation:
helm lint charts/milvushelm template defaulttest charts/milvushelm template grouptest charts/milvus ... groups ...helm template legacytest charts/milvus --set replicaResourceGroups[0]=rg-a --set replicaResourceGroups[1]=rg-bhelm template badtest charts/milvus --set proxy.groups[0].replicas=1verified the missing group name errorgit diff --checkChecklist
[mychartname])