Conversation
The extraEnv and volumeMounts blocks were rendered with a mix of template indentation and the indent filter, producing invalid YAML when either value is configured (e.g. "did not find expected key"). Switch to toYaml with nindent so list items align with the rest of the chart's block sequence style. Fixes zilliztech#235 Signed-off-by: Federico Nafria <federico.nafria@athoscommerce.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: driv The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
Welcome @driv! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #235. The
extraEnvandvolumeMountsblocks in the tei chart's StatefulSet template were rendered using a combination of literal template indentation and theindentfilter, which produced invalid YAML whenever either value was configured (e.g.error converting YAML to JSON: yaml: line 51: did not find expected key).This switches both blocks to
toYaml | nindent, so list items align with the chart's existing block-sequence style (same indent asargs/ports).Example, before:
After:
Checklist
[mychartname])