Skip to content

fix: do not spread key on render props #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kris-ellery wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not spread key on render props #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/ReactSlider/ReactSlider.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,9 +350,9 @@ class ReactSlider extends React.Component {
snapDragDisabled: false,
invert: false,
marks: [],
renderThumb: props => <div {...props} />,
renderTrack: props => <div {...props} />,
renderMark: props => <span {...props} />,
renderThumb: ({ key, ...props }) => <div key={key} {...props} />,
Copy link
Copy Markdown

@m1nsuppp m1nsuppp Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch👍

Copy link
Copy Markdown

@shubhankartrivedi shubhankartrivedi Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed my issue! thanks!

renderTrack: ({ key, ...props }) => <div key={key} {...props} />,
renderMark: ({ key, ...props }) => <span key={key} {...props} />,
};

constructor(props) {
Expand Down