Skip to content

Use "Faster Subgroup Checks for BLS12-381" for is_torsion_free - #80

Closed
zanebeckwith wants to merge 1 commit into
zkcrypto:mainfrom
zanebeckwith:subgroup-via-endo
Closed

Use "Faster Subgroup Checks for BLS12-381" for is_torsion_free#80
zanebeckwith wants to merge 1 commit into
zkcrypto:mainfrom
zanebeckwith:subgroup-via-endo

Conversation

@zanebeckwith

Copy link
Copy Markdown

This uses @ebfull's method for faster subgroup checks

I didn't know if maybe there's a specific reason you all aren't already using these methods here. If so, sorry for the noise!

On my Core i7 Macbook Pro, the "G1Affine subgroup check" benchmark takes:

Similarly, the "G2Affine subgroup check" benchmark takes:

  • 1.6ms on main
  • 175us with these changes

@ebfull

ebfull commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Closing in favor of #83.

@ebfull ebfull closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants