Skip to content

Close connection when TimeoutConnection wrapping fails #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zakird merged 3 commits into from
Jun 28, 2026
+2 −0
Merged

Close connection when TimeoutConnection wrapping fails #743

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0895de2
Close connection when TimeoutConnection wrapping fails
Seanstoppable Jun 22, 2026
3bc47a3
Merge branch 'master' into ssmith/fix-conn-leak
zakird Jun 28, 2026
c5065fe
Merge branch 'master' into ssmith/fix-conn-leak
zakird Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,8 @@ func (d *Dialer) DialContext(ctx context.Context, network, address string) (net.
}
ret, err := NewTimeoutConnection(ctx, conn, d.SessionTimeout, d.ReadTimeout, d.WriteTimeout, d.BytesReadLimit)
if err != nil {
// Avoid leaking the established connection if wrapping it fails.
_ = conn.Close()
return nil, err
}
ret.BytesReadLimit = d.BytesReadLimit
Expand Down