Drop carry-patch, bump manifold pin past #1690 merge (v0.4.0)#14
Merged
Conversation
Manifold's `MANIFOLD_NO_IOSTREAM` build option is now upstream (merged in elalish/manifold#1690 on 2026-05-04). The single vendored carry-patch shipped at v0.4.0-alpha.1 is no longer needed — manifold owns the option, and its `manifoldDeps.cmake` carries a Clipper2 tracking patch for AngusJohnson/Clipper2#1094 internally. The shim drops the carry-patch entirely: * `cmake/manifold-patches/0001-manifold-no-iostream.patch` deleted (and the now-empty directory removed). * `wasm_cxx_shim_add_manifold()`'s SKIP_BUILTIN_PATCHES argument removed (no builtin patches to skip). MANIFOLD_GIT_TAG and EXTRA_MANIFOLD_PATCHES continue to work. * `install(DIRECTORY .../manifold-patches ...)` rule dropped. * Helper smoke test updated for the new file layout. Manifold pin bumped from `5f95a3ac` (master pre-#1690) to `3ce9622b` (master at release time, includes #1690 + one downstream commit). Build + test verified end-to-end on the new pin: 18/18 ctest, 121/121 inner manifold tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manifold's
MANIFOLD_NO_IOSTREAMbuild option is now upstream — elalish/manifold#1690 merged on 2026-05-04. The single vendored carry-patch shipped at v0.4.0-alpha.1 is no longer needed; manifold owns the option natively, and itsmanifoldDeps.cmakecarries a Clipper2 tracking patch for AngusJohnson/Clipper2#1094 internally.This is the v0.4.0 (non-alpha) release the alpha tag was tracking.
What changed
Removed:
cmake/manifold-patches/0001-manifold-no-iostream.patch(and the now-empty directory).SKIP_BUILTIN_PATCHESargument fromwasm_cxx_shim_add_manifold()(no builtin patches to skip).MANIFOLD_GIT_TAGandEXTRA_MANIFOLD_PATCHEScontinue to work.install(DIRECTORY .../manifold-patches ...)rule.Changed:
MANIFOLD_GIT_TAGbumped from5f95a3ac(master pre-#1690) to3ce9622b(master at release time, includes #1690 + one downstream commit).check-manifold-helper.cmake) updated for the new file layout.test/manifold-link/,test/manifold-tests/) updated to reflect the post-merge state.## v0.4.0section.Test plan
ctest --preset wasm32: 18/18 pass withWASM_CXX_SHIM_BUILD_MANIFOLD_LINK=ON.manifold_link_imports_check+manifold_tests_imports_checkstill pass — zero unexpected imports.manifold-patches/or the deleted patch outside CHANGELOG/plan.md historical narrative.Notes
v0.4.0plain — no+<sha>build metadata since the carry-patch is gone and we're tracking master directly.wasm-cxx-shimdependency to v0.4.0 once this lands.🤖 Generated with Claude Code