feat: require permissions to use debug with modifiable actuator#4820
Open
pablocarle wants to merge 25 commits into
Open
feat: require permissions to use debug with modifiable actuator#4820pablocarle wants to merge 25 commits into
pablocarle wants to merge 25 commits into
Conversation
added 3 commits
July 14, 2026 14:57
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
…-debug Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
added 4 commits
July 21, 2026 10:37
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
added 3 commits
July 21, 2026 13:36
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
pablocarle
marked this pull request as ready for review
July 21, 2026 12:19
added 5 commits
July 21, 2026 14:28
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
taban03
reviewed
Jul 22, 2026
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
taban03
reviewed
Jul 22, 2026
taban03
reviewed
Jul 22, 2026
taban03
reviewed
Jul 22, 2026
| .authenticated() | ||
| ) | ||
| .authorizeExchange(exchange -> exchange.matchers(pathMatchers("/application/**")) | ||
| .access(new SafAuthorizationManager<>(safResourceAccessVerifying, "ZOWE", "APIML.DEBUG", "CONTROL")) |
Contributor
There was a problem hiding this comment.
they can extracted as constants and used in both apiml and gw websecuirty config
taban03
reviewed
Jul 22, 2026
| )) | ||
| .authenticated() | ||
| ) | ||
| .authorizeExchange(exchange -> exchange.matchers(pathMatchers("/application/**")) |
Contributor
There was a problem hiding this comment.
is it intentional to require saf resource access for all the requests that are not HEAD and GET?
Contributor
Author
There was a problem hiding this comment.
yes, the other ones are all doing some sort of on-the-fly modification of the application
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
taban03
reviewed
Jul 22, 2026
| } | ||
| } | ||
| ) | ||
| .authorizeExchange(exchange -> exchange.matchers( |
Contributor
There was a problem hiding this comment.
could these rules be combined inside a single authorizeExchange block? something like:
.authorizeExchange(exchanges -> exchanges
.pathMatchers(HttpMethod.GET, "/application/**").authenticated()
.pathMatchers(HttpMethod.HEAD, "/application/**").authenticated()
.anyExchange().access(new SafAuthorizationManager<>(
safResourceAccessVerifying,
"ZOWE",
"APIML.DEBUG",
"CONTROL"
))
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR XX introduced the possibility of using the actuator /loggers and /gateway endpoints in debug mode. This PR adds restrictions to use it. Normal debug profile allows using them but in view-only mode.
A new debug profile is included to enable them in modifiy mode, but they will require an additional SAF resource on the user.
Also fix the acceptance tests in apiml and gateway-service modules to prioritize the production properties and only override what's needed for tests.
Type of change
Checklist: