Skip to content

fix: check for null entries in eureka properties#4829

Open
pablocarle wants to merge 3 commits into
v3.x.xfrom
reboot/fix/metadata-filter-v3
Open

fix: check for null entries in eureka properties#4829
pablocarle wants to merge 3 commits into
v3.x.xfrom
reboot/fix/metadata-filter-v3

Conversation

@pablocarle

Copy link
Copy Markdown
Contributor

Description

If a service does not define certain eureka properties such as health check relative paths, the respective property ends up being a malformed URL. This PR is a proposal for this sort of scenario.

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>

@arxioly arxioly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood that we don't want a breaking change, but shouldn't we fix later the problem with "null" in secureHealthCheckUrl?

@pablocarle

Copy link
Copy Markdown
Contributor Author

I understood that we don't want a breaking change, but shouldn't we fix later the problem with "null" in secureHealthCheckUrl?

This is a standard eureka field, we could provide a simple default during onboarding also

pablocarle and others added 2 commits July 21, 2026 13:39
Co-authored-by: Elena Kubantseva <elena.kubantseva@broadcom.com>
Signed-off-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: Pablo Carle <pablocarle@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants