BREAKING CHANGE: remove apiml.service.allowEncodedSlashes in favor of enableStrictUrlValidation#4830
Open
richard-salac wants to merge 5 commits into
Conversation
…ictUrlValidation The `apiml.service.allowEncodedSlashes` option only ever controlled the encoded slash (%2F) via a Spring Cloud Gateway filter, and its permissive direction was already superseded by `apiml.security.enableStrictUrlValidation`, which governs the StrictServerWebExchangeFirewall (encoded slash, double slash, backslash, encoded percent, encoded period, semicolon). Removes the property and its ForbidEncodedSlashesFilterFactory / ForbidSlashException / exception handler / log message (ZWEAG702), along with the config defaults, packaging start scripts, config schemas, dev scripts and integration-test environment mappings. Adds acceptance tests for gateway-service and the apiml modulith that validate enableStrictUrlValidation across every controlled character, for both routed traffic (relaxed when disabled) and internal endpoints (always strict). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
…_of_enableStrictUrlValidation
Signed-off-by: Richard Salac <richard.salac@broadcom.com>
|
richard-salac
marked this pull request as ready for review
July 22, 2026 05:04
achmelo
reviewed
Jul 22, 2026
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Copyright Contributors to the Zowe Project. | ||
| */ |
Member
There was a problem hiding this comment.
How are these tests different from those in the apiml module?
Contributor
Author
There was a problem hiding this comment.
From functional point of view, they are the same. I put them there to validate the new firewall is initialized consistently in micro services and modulith.
…_of_enableStrictUrlValidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
apiml.service.allowEncodedSlashesoption only ever controlled the encoded slash (%2F) via a Spring Cloud Gateway filter, and its permissive direction was already superseded byapiml.security.enableStrictUrlValidation, which governs the StrictServerWebExchangeFirewall (encoded slash, double slash, backslash, encoded percent, encoded period, semicolon).Removes the property and its ForbidEncodedSlashesFilterFactory / ForbidSlashException / exception handler / log message (ZWEAG702), along with the config defaults, packaging start scripts, config schemas, dev scripts and integration-test environment mappings.
Adds acceptance tests for gateway-service and the apiml modulith that validate enableStrictUrlValidation across every controlled character, for both routed traffic (relaxed when disabled) and internal endpoints (always strict).
Follow up on #4812
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline