fix: Add validation IP address of registered service against allowed list#4837
Open
pavel-jares-bcm wants to merge 28 commits into
Open
fix: Add validation IP address of registered service against allowed list#4837pavel-jares-bcm wants to merge 28 commits into
pavel-jares-bcm wants to merge 28 commits into
Conversation
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
15 tasks
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
pablocarle
reviewed
Jul 24, 2026
|
|
||
| private static final String ORG_ZOWE_APIML_COMMON_URL_NOT_ALLOWED = "org.zowe.apiml.common.urlNotAllowed"; | ||
|
|
||
| private final Cache<String, InetAddress[]> DOMAIN_TO_IP_ADDRESSES = Caffeine.newBuilder() |
Contributor
There was a problem hiding this comment.
Suggested change
| private final Cache<String, InetAddress[]> DOMAIN_TO_IP_ADDRESSES = Caffeine.newBuilder() | |
| private static final Cache<String, InetAddress[]> DOMAIN_TO_IP_ADDRESSES = Caffeine.newBuilder() |
Contributor
Author
There was a problem hiding this comment.
A removed static because the class is singleton and it is necessary to clean during the testing. But I can revert it if you really thing it matters.
Contributor
There was a problem hiding this comment.
it's just about the sonar finding, if it's not "constant" then just rename the variable to camel
pablocarle
reviewed
Jul 24, 2026
|
|
||
| Register: | ||
| runs-on: ubuntu-latest | ||
| container: |
Contributor
There was a problem hiding this comment.
this stage may need to have some tools installed
…r there) Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pavel Jareš <58428711+pavel-jares-bcm@users.noreply.github.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pablo Carle <pablo.carle@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similirly as #4833 verifies the host name this PR checks IP addresses of onboarded services if they are in allowed list (including conversion from domain name to IP address).
Linked to # (issue)
Part of the # (epic)
Type of change
Checklist: