Add support for data-selector attribute - #104
Closed
mburtscher wants to merge 1 commit into
Closed
Conversation
Author
|
Pull request #73 contains exactly the same solution. Use that one ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
thanks for the great plugin! We wanted to use it to provide a feature tour for our existing web-based software solutions. But we don't like to add extra-id's or classes just to be able to target elements with joyride. So I added support for a "data-selector" attribute which allows selecting the target element with a complex jQuery-selector instead of just ID or class.
Hope you like it :-)