Adding a scrollOffset option to the settings for fixed headers - #149
Closed
itsmattsoria wants to merge 2 commits into
Closed
Adding a scrollOffset option to the settings for fixed headers#149itsmattsoria wants to merge 2 commits into
itsmattsoria wants to merge 2 commits into
Conversation
Author
|
Switched pull request to feature branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using Joyride on an application with a fixed header, and needed to be able to offset the
scrollTopso that whenscrollis set totrue, tips that are at the top of the main container wouldn't be scrolled to (underneath the fixed header). I added ascrollOffsetoption to the settings, which is defaulted to0. I thought this would be a pretty common scenario that others would benefit from.