Instead of "ridden" for cookie contents, store the time of the ride. - #156
Open
coderguy9210 wants to merge 1 commit into
Open
Instead of "ridden" for cookie contents, store the time of the ride.#156coderguy9210 wants to merge 1 commit into
coderguy9210 wants to merge 1 commit into
Conversation
Rather than log "ridden" in the cookie which gives us no real information, log the time the cookie was created. We can then use the cookie later to decide it we want to reshow the tour element(s). Also suggest making the expiration on cookies a setting rather than a default 365 days, but I didn't take that on here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than log "ridden" in the cookie which gives us no real information, log the time the cookie was created. We can then use the cookie later to decide it we want to reshow the tour element(s).
Also suggest making the expiration on cookies a setting rather than a default 365 days, but I didn't take that on here.