Skip to content

fixed bug #123, contiguous pause indices doesn't work #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpalmerlee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed bug #123, contiguous pause indices doesn't work #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions jquery.joyride-2.1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@

// call this method when you want to resume the tour
resume : function () {
methods.set_li();
settings.paused = false;
methods.show();
},

Expand Down Expand Up @@ -240,16 +240,14 @@
var opts = {}, ii, opts_arr = [], opts_len = 0, p,
$timer = null;

// are we paused?
if (settings.$li === undefined || ($.inArray(settings.$li.index(), settings.pauseAfter) === -1)) {

// don't go to the next li if the tour was paused
if (settings.paused) {
settings.paused = false;
} else {
methods.set_li(init);
return;
}

methods.set_li(init);


settings.attempts = 0;

if (settings.$li.length && settings.$target.length > 0) {
Expand Down Expand Up @@ -343,11 +341,6 @@
methods.end();

}
} else {

settings.paused = true;

}

},

Expand Down Expand Up @@ -377,6 +370,11 @@
}
settings.$current_tip.hide();
settings.postStepCallback(settings.$li.index(), settings.$current_tip);

// do we need to pause?
if (!(settings.$li === undefined || ($.inArray(settings.$li.index(), settings.pauseAfter) === -1))) {
settings.paused = true;
}
},

set_li : function (init) {
Expand Down