postStepCallback causing a step in the demo to be skipped. - #94
Open
bradhuffman wants to merge 3 commits into
Open
postStepCallback causing a step in the demo to be skipped.#94bradhuffman wants to merge 3 commits into
bradhuffman wants to merge 3 commits into
Conversation
Not sure what the intention was, but the example of calling a postStepCallback was causing step 4 to be skipped. Step 4 demonstrated a step being displayed as a modal, so my thought is you'd want to see that. Changed the demo to show an alert between steps demonstrating the capability of a postStepCallback.
|
Related to issue #91. |
Contributor
|
Could you update your pull request? |
Contributor
Author
|
Not sure what you mean by update my pull request. Close it? |
Contributor
|
@bradhuffman Sorry, merge master into your branch so that it can be automagically merged in. |
Conflicts: demo/demo.html Test Commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure what the intention was, but the example of calling a
postStepCallback was causing step 4 to be skipped. Step 4 demonstrated
a step being displayed as a modal, so my thought is you'd want to see
that. Changed the demo to show an alert between steps demonstrating the
capability of a postStepCallback.