Skip to content

refactor(whatsrust): extract presence wrappers - #313

Merged
Andiveli merged 3 commits into
betafrom
refactor/whatsrust-presence-wrappers
Aug 27, 2026
Merged

refactor(whatsrust): extract presence wrappers#313
Andiveli merged 3 commits into
betafrom
refactor/whatsrust-presence-wrappers

Conversation

@Andiveli

Copy link
Copy Markdown
Owner

Summary

  • Extract raw presence diagnostics, callback ingress counters, and presence subscription wrappers from the whatsrust facade.
  • Preserve diagnostic ownership, counter reset behavior, ABI calls, and public result mapping.

Changes

  • Added whatsrust/src/presence.rs.
  • Re-exported SubscribePresenceResult, drain_raw_presence_diagnostics, and subscribe_presence from lib.rs.
  • Kept callback registration behavior unchanged while routing ingress counting through the presence seam.

Chain Context

  • Start: PR refactor(whatsrust): extract lifecycle wrappers #312 (refactor/whatsrust-lifecycle-wrappers).
  • End: presence wrappers isolated; media and action slices remain.
  • Dependency: this PR is the immediate parent for the media slice.
  • Diagram: #301 -> #311 -> #312 -> 📍 #313 -> #314 -> #315.
  • Deferred: Cargo compilation/tests are intentionally deferred per task instructions; only formatting/source/diff checks were run.
  • Rollback: revert commit 9d43523 / remove presence.rs and restore the presence block in lib.rs; no unrelated behavior changes.

Testing

  • cargo fmt --check
  • git diff --check
  • Source and authored-line budget checks
  • Cargo tests/build (deferred; no Cargo build/test command run)
  • Manual runtime testing (not applicable to this mechanical extraction)

Closes #308

@Andiveli Andiveli added the type:refactor Code refactoring label Aug 26, 2026
@Andiveli
Andiveli changed the base branch from refactor/whatsrust-lifecycle-wrappers to beta August 27, 2026 00:15
@Andiveli
Andiveli merged commit 6daea55 into beta Aug 27, 2026
1 check passed
@Andiveli
Andiveli deleted the refactor/whatsrust-presence-wrappers branch August 31, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant