Skip to content

refactor(whatsrust): remove final facade-owned definitions - #337

Merged
Andiveli merged 1 commit into
betafrom
refactor/whatsrust-facade-final-cleanup
Aug 27, 2026
Merged

refactor(whatsrust): remove final facade-owned definitions#337
Andiveli merged 1 commit into
betafrom
refactor/whatsrust-facade-final-cleanup

Conversation

@Andiveli

Copy link
Copy Markdown
Owner

Summary

Changes

  • Moved CallbackTranslator<CJID> for JID to models.rs.
  • Moved CallbackTranslator<i64> for i64 to registrations.rs.
  • Moved VIEW_ONCE_UNAVAILABLE_DESCRIPTION to models.rs and reexported it.
  • Relocated required CString imports to their owning modules and removed the lib.rs residue.

Chain Context

Testing

  • cargo fmt --all -- --check
  • CARGO_TARGET_DIR=/home/samael/Escritorio/public/wptui-public/target cargo check --workspace --all-targets
  • CARGO_TARGET_DIR=/home/samael/Escritorio/public/wptui-public/target cargo test -p whatsrust --lib -- --test-threads=1 (24 passed)
  • CARGO_TARGET_DIR=/home/samael/Escritorio/public/wptui-public/target cargo test --test whatsrust_api_contract -- --test-threads=1 (1 passed)
  • go test ./... and go vet ./... in whatsrust/lib (passed)
  • git diff --check
  • Full cargo test --workspace -- --test-threads=1: attempted, but the shared filesystem had no free space (No space left on device).
  • Manual/runtime testing: N/A; this is a source ownership refactor with no behavior change.

Review Budget and Rollback

Contributor Checklist

Closes #336

@Andiveli Andiveli added the type:refactor Code refactoring label Aug 26, 2026
@Andiveli
Andiveli changed the base branch from refactor/whatsrust-facade-final to beta August 27, 2026 03:00
@Andiveli
Andiveli merged commit e139d1c into beta Aug 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant