refactor(whatsrust): remove final facade-owned definitions - #337
Merged
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whatsrust/src/lib.rs.Changes
CallbackTranslator<CJID> for JIDtomodels.rs.CallbackTranslator<i64> for i64toregistrations.rs.VIEW_ONCE_UNAVAILABLE_DESCRIPTIONtomodels.rsand reexported it.CStringimports to their owning modules and removed the lib.rs residue.Chain Context
refactor/whatsrust-facade-finalat7a4d8b1.whatsrust/src/lib.rsis a 54-line module-and-reexport facade with no constants, impls, unsafe blocks, or logic.Testing
cargo fmt --all -- --checkCARGO_TARGET_DIR=/home/samael/Escritorio/public/wptui-public/target cargo check --workspace --all-targetsCARGO_TARGET_DIR=/home/samael/Escritorio/public/wptui-public/target cargo test -p whatsrust --lib -- --test-threads=1(24 passed)CARGO_TARGET_DIR=/home/samael/Escritorio/public/wptui-public/target cargo test --test whatsrust_api_contract -- --test-threads=1(1 passed)go test ./...andgo vet ./...inwhatsrust/lib(passed)git diff --checkcargo test --workspace -- --test-threads=1: attempted, but the shared filesystem had no free space (No space left on device).Review Budget and Rollback
5cbbd3d.5cbbd3d; this removes only the final facade ownership cleanup and restores PR refactor(whatsrust): remove residual facade test copies #335 source layout.Contributor Checklist
type:*label:type:refactor.Co-Authored-Bytrailer.Closes #336