[2.0.0-dev] use jthread now that it's available in libc++20#1389
Merged
spoonincode merged 2 commits intorelease/2.0from Apr 16, 2025
Merged
[2.0.0-dev] use jthread now that it's available in libc++20#1389spoonincode merged 2 commits intorelease/2.0from
jthread now that it's available in libc++20#1389spoonincode merged 2 commits intorelease/2.0from
Conversation
heifner
approved these changes
Apr 16, 2025
greg7mdp
approved these changes
Apr 16, 2025
spoonincode
changed the title
jthread now that's it's available in libc++20jthread now that it's available in libc++20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jthreadhas been available in libstdc++ since 10 so no problem compiling on ubuntu20's gcc with it even. But have been blocked using it by it not being available (without enabling experimental features) in libc++ until now.Probably breaks mac builds 🤷♀️ Lousy to break unofficial mac support via this but it's a c++20 feature and the year is 2025.