Skip to content

[2.0.0-dev] use jthread now that it's available in libc++20 #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spoonincode merged 2 commits into from
Apr 16, 2025
Merged

[2.0.0-dev] use jthread now that it's available in libc++20 #1389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf265d
use jthread
spoonincode Apr 16, 2025
18beae3
Merge branch '20_repro_clang_20' into 20_use_jthread
spoonincode Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions libraries/chain/include/eosio/chain/thread_utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,13 +286,7 @@ namespace eosio { namespace chain {
template<typename Rep, typename Period, typename F>
void run(const unsigned num_threads, const std::chrono::duration<Rep, Period>& ping_interval, F&& ping) {
std::vector<std::promise<void>> thread_promises(num_threads);
std::list<std::thread> threads;

//this scoped_exit can go away with jthread; but still marked experimental in libc++18
auto join = fc::make_scoped_exit([&threads]() {
for(std::thread& t : threads)
t.join();
});
std::list<std::jthread> threads;

for(unsigned i = 0; i < num_threads; ++i)
threads.emplace_back([this, i, &prom = thread_promises[i]] {
Expand Down