Skip to content

chore: remove release-please workflow and configs#23401

Merged
AztecBot merged 1 commit into
nextfrom
cb/b11d0124e2cf
May 20, 2026
Merged

chore: remove release-please workflow and configs#23401
AztecBot merged 1 commit into
nextfrom
cb/b11d0124e2cf

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

@AztecBot AztecBot commented May 19, 2026

Summary

Conservative pass on next — keeps .release-please-manifest.json (still used as the version source by bootstrap.sh, workflows, ci3/source_refname, playground, telemetry, pxe, spartan scripts, release-image Docker, etc.) and removes only the release-please tooling and stale doc references.

Removed

  • .github/workflows/release-please.yml — the googleapis/release-please-action workflow
  • .github/release-please-master.json, -v2.json, -v3.json, -v4.json — release-please configs
  • The x-release-please-* magic-comment blocks in both Docusaurus configs (these were release-please tool markers)

Doc updates (no functional changes)

  • README.md Releases paragraph — points at tags + manifest instead of release-please
  • bootstrap.sh comment — drop "release-please creates it" aside
  • docs/scripts/cli_reference_generation/CLI_DOCS_README.md — drop dead release-please.yml reference
  • spartan/testnet-runbook.md — describe tag-driven release instead of "initiate a release-please workflow"
  • .claude/skills/merge-train-infra — describe BEGIN/END_COMMIT_OVERRIDE markers without claiming they're consumed by release-please
  • yarn-project/BRANCHING.md — fix one dead link to release-please.yml; the rest of BRANCHING.md (including v2's still-active release-please description and all .release-please-manifest.json references) is left alone

Intentionally NOT touched (per "more conservative" scope)

  • .release-please-manifest.json — kept as the canonical version source
  • create-release-branch.yml — still bumps .release-please-manifest.json (manifest stays)
  • All workflows / bash / TS / JS that read the manifest — all unchanged
  • docs/README.md macro paragraph naming the manifest — still accurate
  • .claude/skills/updating-changelog — still tells you to read the manifest
  • .claude/skills/noir-sync-update — references the noir submodule's own manifest, out of scope
  • v2's release-please description in BRANCHING.mdv2 still has release-please; only next changes
  • v4-next — companion PR chore: remove release-please (v4-next) #23402 closed; only next per request

13 files changed, 6 insertions(+), 436 deletions(-).

Test plan

  • CI green (no consumer touched, no version-resolution path changed)
  • release-image build still stamps .release-please-manifest.json and aztec --version is correct

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label May 19, 2026
@AztecBot AztecBot changed the title chore: remove release-please (next) chore: remove release-please workflow and configs (next) May 19, 2026
@ludamad ludamad added backport-to-v4 and removed claudebox Owned by claudebox. it can push to this PR. labels May 19, 2026
@ludamad ludamad marked this pull request as ready for review May 19, 2026 23:55
@ludamad ludamad requested a review from charlielye as a code owner May 19, 2026 23:55
@ludamad ludamad changed the title chore: remove release-please workflow and configs (next) chore: remove release-please workflow and configs May 19, 2026
@AztecBot AztecBot enabled auto-merge May 20, 2026 00:20
## Summary

Conservative pass on `next` — keeps `.release-please-manifest.json` (still used as the version source by `bootstrap.sh`, workflows, `ci3/source_refname`, playground, telemetry, pxe, spartan scripts, release-image Docker, etc.) and removes only the release-please tooling and stale doc references.

### Removed
- `.github/workflows/release-please.yml` — the googleapis/release-please-action workflow
- `.github/release-please-master.json`, `-v2.json`, `-v3.json`, `-v4.json` — release-please configs
- The `x-release-please-*` magic-comment blocks in both Docusaurus configs (these were release-please tool markers)

### Doc updates (no functional changes)
- `README.md` Releases paragraph — points at tags + manifest instead of release-please
- `bootstrap.sh` comment — drop "release-please creates it" aside
- `docs/scripts/cli_reference_generation/CLI_DOCS_README.md` — drop dead `release-please.yml` reference
- `spartan/testnet-runbook.md` — describe tag-driven release instead of "initiate a release-please workflow"
- `.claude/skills/merge-train-infra` — describe `BEGIN/END_COMMIT_OVERRIDE` markers without claiming they're consumed by release-please
- `yarn-project/BRANCHING.md` — fix one dead link to `release-please.yml`; the rest of BRANCHING.md (including v2's still-active release-please description and all `.release-please-manifest.json` references) is left alone

### Intentionally NOT touched (per "more conservative" scope)
- `.release-please-manifest.json` — kept as the canonical version source
- `create-release-branch.yml` — still bumps `.release-please-manifest.json` (manifest stays)
- All workflows / bash / TS / JS that read the manifest — all unchanged
- `docs/README.md` macro paragraph naming the manifest — still accurate
- `.claude/skills/updating-changelog` — still tells you to read the manifest
- `.claude/skills/noir-sync-update` — references the noir submodule's own manifest, out of scope
- v2's release-please description in `BRANCHING.md` — `v2` still has release-please; only `next` changes
- `v4-next` — companion PR #23402 closed; only `next` per request

13 files changed, 6 insertions(+), 436 deletions(-).

## Test plan
- [ ] CI green (no consumer touched, no version-resolution path changed)
- [ ] release-image build still stamps `.release-please-manifest.json` and `aztec --version` is correct
@AztecBot AztecBot added this pull request to the merge queue May 20, 2026
@aminsammara
Copy link
Copy Markdown
Contributor

LGTM!

@AztecBot
Copy link
Copy Markdown
Collaborator Author

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/620d9ca12a0b4fd1�620d9ca12a0b4fd18;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/duplicate_proposal_slash.test.ts (175s) (code: 0) group:e2e-p2p-epoch-flakes

Merged via the queue into next with commit e597440 May 20, 2026
21 checks passed
@AztecBot AztecBot deleted the cb/b11d0124e2cf branch May 20, 2026 14:39
@AztecBot
Copy link
Copy Markdown
Collaborator Author

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants