Skip to content

chore: remove release-please (v4-next)#23402

Closed
AztecBot wants to merge 3 commits into
v4-nextfrom
cb/remove-release-please-v4-next
Closed

chore: remove release-please (v4-next)#23402
AztecBot wants to merge 3 commits into
v4-nextfrom
cb/remove-release-please-v4-next

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

@AztecBot AztecBot commented May 19, 2026

Closing — superseded by a more conservative pass scoped to next only (#23401). Keeping .release-please-manifest.json and all its consumers untouched there; only removing the release-please workflow, configs, and doc references.

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label May 19, 2026
@AztecBot AztecBot closed this May 19, 2026
AztecBot added a commit that referenced this pull request May 20, 2026
## Summary

Conservative pass on `next` — keeps `.release-please-manifest.json` (still used as the version source by `bootstrap.sh`, workflows, `ci3/source_refname`, playground, telemetry, pxe, spartan scripts, release-image Docker, etc.) and removes only the release-please tooling and stale doc references.

### Removed
- `.github/workflows/release-please.yml` — the googleapis/release-please-action workflow
- `.github/release-please-master.json`, `-v2.json`, `-v3.json`, `-v4.json` — release-please configs
- The `x-release-please-*` magic-comment blocks in both Docusaurus configs (these were release-please tool markers)

### Doc updates (no functional changes)
- `README.md` Releases paragraph — points at tags + manifest instead of release-please
- `bootstrap.sh` comment — drop "release-please creates it" aside
- `docs/scripts/cli_reference_generation/CLI_DOCS_README.md` — drop dead `release-please.yml` reference
- `spartan/testnet-runbook.md` — describe tag-driven release instead of "initiate a release-please workflow"
- `.claude/skills/merge-train-infra` — describe `BEGIN/END_COMMIT_OVERRIDE` markers without claiming they're consumed by release-please
- `yarn-project/BRANCHING.md` — fix one dead link to `release-please.yml`; the rest of BRANCHING.md (including v2's still-active release-please description and all `.release-please-manifest.json` references) is left alone

### Intentionally NOT touched (per "more conservative" scope)
- `.release-please-manifest.json` — kept as the canonical version source
- `create-release-branch.yml` — still bumps `.release-please-manifest.json` (manifest stays)
- All workflows / bash / TS / JS that read the manifest — all unchanged
- `docs/README.md` macro paragraph naming the manifest — still accurate
- `.claude/skills/updating-changelog` — still tells you to read the manifest
- `.claude/skills/noir-sync-update` — references the noir submodule's own manifest, out of scope
- v2's release-please description in `BRANCHING.md` — `v2` still has release-please; only `next` changes
- `v4-next` — companion PR #23402 closed; only `next` per request

13 files changed, 6 insertions(+), 436 deletions(-).

## Test plan
- [ ] CI green (no consumer touched, no version-resolution path changed)
- [ ] release-image build still stamps `.release-please-manifest.json` and `aztec --version` is correct
AztecBot added a commit that referenced this pull request May 20, 2026
## Summary

Conservative pass on `next` — keeps `.release-please-manifest.json` (still used as the version source by `bootstrap.sh`, workflows, `ci3/source_refname`, playground, telemetry, pxe, spartan scripts, release-image Docker, etc.) and removes only the release-please tooling and stale doc references.

### Removed
- `.github/workflows/release-please.yml` — the googleapis/release-please-action workflow
- `.github/release-please-master.json`, `-v2.json`, `-v3.json`, `-v4.json` — release-please configs
- The `x-release-please-*` magic-comment blocks in both Docusaurus configs (these were release-please tool markers)

### Doc updates (no functional changes)
- `README.md` Releases paragraph — points at tags + manifest instead of release-please
- `bootstrap.sh` comment — drop "release-please creates it" aside
- `docs/scripts/cli_reference_generation/CLI_DOCS_README.md` — drop dead `release-please.yml` reference
- `spartan/testnet-runbook.md` — describe tag-driven release instead of "initiate a release-please workflow"
- `.claude/skills/merge-train-infra` — describe `BEGIN/END_COMMIT_OVERRIDE` markers without claiming they're consumed by release-please
- `yarn-project/BRANCHING.md` — fix one dead link to `release-please.yml`; the rest of BRANCHING.md (including v2's still-active release-please description and all `.release-please-manifest.json` references) is left alone

### Intentionally NOT touched (per "more conservative" scope)
- `.release-please-manifest.json` — kept as the canonical version source
- `create-release-branch.yml` — still bumps `.release-please-manifest.json` (manifest stays)
- All workflows / bash / TS / JS that read the manifest — all unchanged
- `docs/README.md` macro paragraph naming the manifest — still accurate
- `.claude/skills/updating-changelog` — still tells you to read the manifest
- `.claude/skills/noir-sync-update` — references the noir submodule's own manifest, out of scope
- v2's release-please description in `BRANCHING.md` — `v2` still has release-please; only `next` changes
- `v4-next` — companion PR #23402 closed; only `next` per request

13 files changed, 6 insertions(+), 436 deletions(-).

## Test plan
- [ ] CI green (no consumer touched, no version-resolution path changed)
- [ ] release-image build still stamps `.release-please-manifest.json` and `aztec --version` is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant