-
Notifications
You must be signed in to change notification settings - Fork 1
docs: refine Security Batch governance hooks and CI smoke-fast schedule #19502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| name: Security Batch | ||
| description: Recurring sprint issue for security dashboard triage, CIS benchmark checks, and CI readiness. | ||
| title: "Security Batch: YYYY-MM-DD" | ||
| labels: | ||
| - "type:security" | ||
| - "area:security" | ||
| - "lane:security" | ||
| assignees: [] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| ## Security Batch Sprint | ||
| Use this template to run the recurring security batch. Reference: | ||
| - Runbook: docs/security/SECURITY_BATCH.md | ||
| - CIS checks: docs/security/SECURITY_CIS.md | ||
| - Readiness authority: docs/SUMMIT_READINESS_ASSERTION.md | ||
| - type: input | ||
| id: sprint-window | ||
| attributes: | ||
| label: Sprint window | ||
| description: Planned dates for this security batch. | ||
| placeholder: "2026-02-10 → 2026-02-24" | ||
| validations: | ||
| required: true | ||
| - type: input | ||
| id: owner | ||
| attributes: | ||
| label: Owner | ||
| description: Primary accountable owner for this batch. | ||
| placeholder: "@security-lead" | ||
| validations: | ||
| required: true | ||
| - type: input | ||
| id: dashboard-review | ||
| attributes: | ||
| label: Security dashboard review | ||
| description: Link to GitHub security/code view review and timestamp. | ||
| placeholder: "https://github.com/<org>/<repo>/security/code (reviewed YYYY-MM-DD)" | ||
| validations: | ||
| required: true | ||
| - type: input | ||
| id: cis-run | ||
| attributes: | ||
| label: CIS benchmark run evidence | ||
| description: Link to evidence artifact or report (must be ≤ 7 days old). | ||
| placeholder: "artifacts/security/cis-report-YYYY-MM-DD.md" | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: acceptance-criteria | ||
| attributes: | ||
| label: Acceptance criteria | ||
| value: | | ||
| - [ ] No open **high/critical** alerts in GitHub `security/code` view. | ||
| - [ ] CIS benchmark run completed in the last 7 days and archived. | ||
| - [ ] CI green on `.github/workflows/ci.yml` for touched components. | ||
| - [ ] Security batch findings logged as follow-on issues. | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: execution-log | ||
| attributes: | ||
| label: Execution log | ||
| description: Capture commands, evidence links, and notes. | ||
| placeholder: | | ||
| - Command: ./scripts/security-hardening-suite.sh (CIS validation) | ||
| - Evidence: <link> | ||
| - Notes: ... | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: governed-exceptions | ||
| attributes: | ||
| label: Governed Exceptions | ||
| description: List approved exceptions with links to approval records (if any). | ||
| placeholder: | | ||
| - Exception ID: EX-YYYY-### | ||
| Approval: <link> | ||
| Scope: <scope> | ||
| validations: | ||
| required: true | ||
| - type: checkboxes | ||
| id: verification | ||
| attributes: | ||
| label: Verification | ||
| options: | ||
| - label: CI workflow results reviewed (ci.yml) | ||
| - label: CIS benchmark evidence attached | ||
| - label: Security dashboard alerts triaged | ||
| - label: Follow-on issues created and labeled lane:security | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Security Batch Runbook | ||
|
|
||
| **Purpose:** Standardize recurring security batch sprints for dashboard triage, CIS benchmark | ||
| validation, and remediation intake. | ||
|
|
||
| ## References | ||
|
|
||
| - Primary playbook: [SECURITY_BATCH_1_PLAYBOOK.md](SECURITY_BATCH_1_PLAYBOOK.md) | ||
| - CIS benchmark guidance: [SECURITY_CIS.md](SECURITY_CIS.md) | ||
| - Security pipeline controls: [security-pipeline.md](security-pipeline.md) | ||
| - Readiness authority: [SUMMIT_READINESS_ASSERTION.md](../SUMMIT_READINESS_ASSERTION.md) | ||
|
|
||
| ## Execution Steps | ||
|
|
||
| 1. **Open the Security Batch issue** using the `Security Batch` issue template. | ||
| 2. **Review GitHub Security Dashboard** (`/security/code`): | ||
| - Triage all high/critical alerts. | ||
| - Link each alert to a follow-on issue labeled `lane:security`. | ||
| 3. **Run CIS benchmark validation** using the CIS runbook and capture evidence artifacts. | ||
| 4. **Verify CI health** for `.github/workflows/ci.yml` on touched components. | ||
| 5. **Record outcomes** in the batch issue: | ||
| - Evidence links | ||
| - Exceptions (if any) as **Governed Exceptions** with links to approval records | ||
| - Follow-on issue links | ||
|
|
||
| ## Acceptance Criteria | ||
|
|
||
| - No open high/critical alerts in GitHub `security/code` view. | ||
| - Latest CIS benchmark run ≤ 7 days old and archived. | ||
| - CI green for `ci.yml` on touched components. | ||
| - Follow-on issues created and labeled `lane:security`. | ||
|
|
||
| ## Escalation | ||
|
|
||
| Escalate unresolved high/critical alerts to Security Leadership and Release Captain per | ||
| [SECURITY_OPERATIONS.md](SECURITY_OPERATIONS.md). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # CIS Benchmark Validation Runbook | ||
|
|
||
| **Purpose:** Provide a repeatable, auditable CIS benchmark validation procedure for Summit. | ||
|
|
||
| ## Preconditions | ||
|
|
||
| - Access to the target Kubernetes cluster context. | ||
| - `kubectl`, `trivy`, and `cosign` installed in the execution environment. | ||
| - Read access to `scripts/security-hardening-suite.sh`. | ||
|
|
||
| ## Primary Run | ||
|
|
||
| Use the security hardening suite to perform baseline CIS validation and related checks: | ||
|
|
||
| ```bash | ||
| ./scripts/security-hardening-suite.sh | ||
| ``` | ||
|
|
||
| This suite performs the following CIS-aligned checks: | ||
|
|
||
| - Pod Security Standards enforcement. | ||
| - Network policy coverage inspection. | ||
| - Privileged container detection. | ||
| - Image signature validation via `cosign`. | ||
| - RBAC permission validation. | ||
| - Vulnerability scan via `trivy`. | ||
|
|
||
| ## Evidence Capture | ||
|
|
||
| - Save the generated `security-hardening-report-<timestamp>.md` to the security evidence store. | ||
| - Attach the report link in the Security Batch issue template under **CIS benchmark run evidence**. | ||
|
|
||
| ## Validation Cadence | ||
|
|
||
| - **Requirement:** Latest CIS benchmark run must be ≤ 7 days old. | ||
| - **Failure Handling:** Record deviations as **Governed Exceptions** with approval links and open a | ||
| follow-on issue labeled `lane:security`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
verificationcheckboxes seem redundant as they largely overlap with the items in theacceptance-criteriachecklist. This could lead to confusion and unnecessary duplication of effort.To simplify the template, I suggest removing this
verificationsection entirely. You could also consider changing theacceptance-criteriafrom atextareato acheckboxestype to make it a more direct and enforceable checklist. For example:This would make the template clearer and more streamlined.