Skip to content

Better mesh generation + missing kernels#206

Merged
vladotomov merged 10 commits intomasterfrom
updates-feb-26
Feb 17, 2026
Merged

Better mesh generation + missing kernels#206
vladotomov merged 10 commits intomasterfrom
updates-feb-26

Conversation

@vladotomov
Copy link
Copy Markdown
Member

No description provided.

Comment thread laghos.cpp Outdated
Comment thread laghos.cpp Outdated
Comment thread laghos.cpp
// 2D Q3Q2 - ok.
// 2D Q4Q3.
TENS::Specialization<2,QVectorLayout::byNODES,1,4,8>::Opt<1>::Add();
TENS::Specialization<2,QVectorLayout::byVDIM,2,5,8>::Opt<1>::Add();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires mfem/mfem#5227 for CUDA/HIP

Comment thread laghos.cpp
Comment on lines +318 to +319
mesh = PartitionMPI(dim, Mpi::WorldSize(), elem_per_mpi, myid == 0,
rp_levels, mpi_partitioning);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to extend this function to allow generating domains which are not the unit square/cube (similar to the Sx/Sy/Sz options I added to #205) so you can generate meshes for the triple point problem? I think this would also require specific multiples of elements in each dimension to ensure that interface boundaries match element boundaries.

This function also seems to generate some interesting elongated (in terms of zone count per dimension) meshes and only allows cartesian partitioning.

For 512 ranks in 3D I get 16x4x8, 1024 ranks gives 32x4x8. I think I prefer the existing mesh generation method as you can specify the exact domain shape and test metis partitioned mesh communication patterns/balance.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, that won't solve the problem for the 3point mesh. I prefer to keep it simple with [0,1]^dim - the intention is not to test physics, just a generic mesh that can be used for performance tests.

I will debug the weird elongations.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep the Sx/Sy/Sz option + metis. I wanted to replace the complex -partitionning stuff.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vladotomov and others added 2 commits February 10, 2026 08:33
fixed "default"

Co-authored-by: Andrew Ho <ho37@llnl.gov>
Copy link
Copy Markdown
Member

@camierjs camierjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with mfem/mfem#5227 - looks good!

@vladotomov vladotomov merged commit ec5bb93 into master Feb 17, 2026
1 check passed
@vladotomov vladotomov deleted the updates-feb-26 branch February 17, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants