Conversation
tzanio
approved these changes
Feb 11, 2026
helloworld922
approved these changes
Feb 11, 2026
Member
|
This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch. |
Member
|
Merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen in CEED/Laghos#206
PR Checklist
make style.CHANGELOG:CHANGELOGto group with other related features?INSTALL:makeorcmakehave a new target?.github.appveyor.yml.gitignore:make distclean; git statusshows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.examples/makefile:SEQ_EXAMPLESandPAR_EXAMPLESvariables.cleantarget..gitignorefile.examples/CMakeLists.txt:ALL_EXE_SRCSvariable.THIS_TEST_OPTIONSis set correctly for the new example.doc/CodeDocumentation.dox.examples/pumi), list it indoc/CodeDocumentation.conf.insrc/examples.md.src/examples.mdandsrc/img.examples.md, list the example under the appropriate categories, add new categories if necessary.features.md.makefileandmakefilein corresponding miniapp directory..gitignorefile.CMakeLists.txtfile in theminiappsdirectory, if the new miniapp is in a new directory.CMakeLists.txtfile in the new miniapp directory.doc/CodeDocumentation.doxminiapps/nurbs), add it toMINIAPP_SUBDIRSin themakefile.miniapps/nurbs), list it indoc/CodeDocumentation.conf.insrc/meshing.mdandsrc/electromagnetics.mdfiles.src/examples.mdandsrc/img.features.md.mfem/webrepo.README(rare).doc/CodeDocumentation.dox(rare).make unittestto make sure all unit tests pass.tests/scripts.