build(medcat and medcat-den and medcat-embedding-linker): Fix spacy-click issue#518
Merged
Merged
Conversation
| # e.g `spacy`'s dependency `click` isn't installed | ||
| "typer!=0.26.0,!=0.26.1,!=0.26.2", | ||
| "typer!=0.26.*", | ||
| # transitive dependency that spacy needs but doesn't delcare... |
Contributor
There was a problem hiding this comment.
minor - type in declare. same below
Contributor
jocelyneholdbrook
left a comment
jocelyneholdbrook
left a comment
There was a problem hiding this comment.
typo in declare otherwise looks good to me
jocelyneholdbrook
approved these changes
May 29, 2026
mart-r
added a commit
that referenced
this pull request
May 29, 2026
…lick issue (#518) * Explicitly require click as a dependency to fix spacy issue * Explicitly require click as a dependency to fix spacy issue for medcat-den * Explicitly require click as a dependency to fix spacy issue for embedding linker * Unify typer install restrictions * Fix typos in comment --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mart-r
added a commit
that referenced
this pull request
May 29, 2026
…lick issue (#518) * Explicitly require click as a dependency to fix spacy issue * Explicitly require click as a dependency to fix spacy issue for medcat-den * Explicitly require click as a dependency to fix spacy issue for embedding linker * Unify typer install restrictions * Fix typos in comment --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix this once and for all by explicitly requiring
click. Related to #505 and #507.I didn't originally want to add
clickas a dependency since that wasn't the culprit. Buttyperalready managed to get a subsequent release in, and as such broke all our installs again. So I'm going to bite the bullet and have it in here still.EDIT:
Notably, the
typerconstraint isn't actually needed after this change. So may be better off removing it instead of widening it like I did now.